Skip to content

Wave 6a companion: SLAB_LEN +32 + phantom-dust offset-print rename - #276

Merged
dcccrypto merged 1 commit into
mainfrom
feat/sync/wrapper-phantom-dust-rename-wave6a
May 10, 2026
Merged

Wave 6a companion: SLAB_LEN +32 + phantom-dust offset-print rename#276
dcccrypto merged 1 commit into
mainfrom
feat/sync/wrapper-phantom-dust-rename-wave6a

Conversation

@dcccrypto

Copy link
Copy Markdown
Owner

Summary

Companion to engine PR dcccrypto/percolator#95 (Wave 6a phantom-dust 4-field schema). Engine grew RiskEngine by +32 bytes; wrapper test fixtures bump in lockstep via path = "../percolator".

What's changed

File Old New Delta
tests/cu_benchmark.rs test tier 19840 19872 +32
tests/cu_benchmark.rs small tier 94368 94400 +32
tests/cu_benchmark.rs medium tier 372480 372512 +32
tests/cu_benchmark.rs production 1484928 1484960 +32
tests/i128_alignment.rs production 1484928 1484960 +32
tests/common/mod.rs LiteSVM-padded 1_525_424 + 512 1_525_456 + 512 +32

Plus a 2-line tests/unit.rs offset-print rename (phantom_dust_bound_*phantom_dust_potential_*) to match the engine field rename.

Cumulative engine fixed-prefix growth from pre-Wave-1: +248 bytes.

Verification

  • cargo build --release clean
  • cargo test --release --lib: 24/0/0
  • cargo test --release --test unit: 18/0/4 (matches baseline)
  • 2 BPF-based test failures (cu_benchmark, i128_alignment) are pre-existing — they need a built .so binary not present in this env. SLAB_LEN constants are correctly bumped for when BPF is rebuilt against post-Wave-6a engine.

Test plan

Cross-repo coordination

Must merge AFTER engine PR #95 (path-dep means the engine field rename must land first or wrapper build breaks).

Next sub-PRs (separate):

  • Wave 6b: dynamic-fee API rename
  • Wave 6c: percolator-nft mirror update for 4-field schema
  • Wave 6d: any further wrapper integration

🤖 Generated with Claude Code

…st schema swap + offset-print rename

Engine PR #95 (Wave 6a) adopted toly's 4-field phantom-dust schema
(2 × u128 → 4 × u128 per side; net +32 bytes on RiskEngine). Coupled
to engine via `path = "../percolator"`, so wrapper test fixtures
must bump in lockstep.

## What's changed

| File | Old | New | Delta |
|---|---|---|---|
| `tests/cu_benchmark.rs` test tier      | 19840    | 19872    | +32 |
| `tests/cu_benchmark.rs` small tier     | 94368    | 94400    | +32 |
| `tests/cu_benchmark.rs` medium tier    | 372480   | 372512   | +32 |
| `tests/cu_benchmark.rs` production     | 1484928  | 1484960  | +32 |
| `tests/i128_alignment.rs` production   | 1484928  | 1484960  | +32 |
| `tests/common/mod.rs` LiteSVM-padded   | 1_525_424 + 512 | 1_525_456 + 512 | +32 |

The 2-line `tests/unit.rs` offset-print update renames
`phantom_dust_bound_<side>_q` → `phantom_dust_potential_<side>_q` to
match the engine field rename. Pure debug-print update; doesn't
affect any runtime behavior or assertion.

Cumulative engine fixed-prefix growth from pre-Wave-1: +16 (Wave 1)
+ +8 (Wave 4a) + +192 (Wave 5) + +32 (Wave 6a) = +248 bytes.

## Verification

| Gate | Result |
|---|---|
| `cargo build --release` | clean (9 pre-existing warnings) |
| `cargo test --release --lib` | 24 / 0 / 0 |
| `cargo test --release --test unit` | 18 / 0 / 4 (matches baseline) |

The 2 BPF-based test files (`cu_benchmark`, `i128_alignment`)
require a built `.so` binary which isn't present in this env;
they were already failing on `main` pre-Wave-6a with the same
`InvalidAccountData` error (litesvm host probe). The SLAB_LEN
constants in those files are bumped in lockstep with the engine
schema so they'll pass once the BPF binary is rebuilt against
post-Wave-6a engine.

## Cross-repo

- Engine Wave 6a (PR #95 — pending CI/merge). Schema bytes +32.
- NFT Wave 6c (next PR): vendored mirror update for 4-field schema.

## Out of scope

- Wave 6b: dynamic-fee API rename (separate PR).
- Wave 6c: percolator-nft mirror update (separate PR).
- Wave 6d: any further wrapper integration (e.g. if dynamic-fee
  changes wrapper handler signatures).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented May 10, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@dcccrypto has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 54 minutes and 48 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9c5b7cd8-0d37-406d-8b69-bd6324561de9

📥 Commits

Reviewing files that changed from the base of the PR and between 0350793 and b318505.

📒 Files selected for processing (4)
  • tests/common/mod.rs
  • tests/cu_benchmark.rs
  • tests/i128_alignment.rs
  • tests/unit.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/sync/wrapper-phantom-dust-rename-wave6a

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dcccrypto
dcccrypto merged commit 4e71c0c into main May 10, 2026
1 check passed
@dcccrypto
dcccrypto deleted the feat/sync/wrapper-phantom-dust-rename-wave6a branch May 10, 2026 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant