Skip to content

fix(nav): "Trade" opens the markets browser instead of one default market - #2461

Open
0x-SquidSol wants to merge 1 commit into
dcccrypto:playgroundfrom
0x-SquidSol:fix/trade-nav-to-markets
Open

fix(nav): "Trade" opens the markets browser instead of one default market#2461
0x-SquidSol wants to merge 1 commit into
dcccrypto:playgroundfrom
0x-SquidSol:fix/trade-nav-to-markets

Conversation

@0x-SquidSol

Copy link
Copy Markdown
Contributor

Problem

The header's Trade button linked to /trade — a redirect page that auto-jumps into SOL-PERP or the highest-volume market. So clicking "Trade" dropped users straight into one arbitrary market (often a brand-new, low-volume one) instead of letting them choose which to trade.

Fix

Point the "Trade" nav link at /markets (the full markets browser) so it opens the list and the user picks the market to open in the terminal.

  • The button is otherwise unchanged — same label, same filled-accent styling, same position — only its destination changes.
  • Applied to both the desktop CTA and the mobile menu link.
  • The tab stays highlighted across the whole trade flow — active on /markets (browser) and /trade/:slab (terminal).
  • aria-label updated ("Trade terminal" → "Trade — browse all markets") to match the destination.
  • The /trade redirect route is left intact for direct hits and old links.

Testing

  • tsc --noEmit clean.
  • Verified in the browser: the "Trade" link's href is /markets; clicking it from an app page lands on /markets; /markets stays put (no redirect) and lists the markets. Screenshot below.

🤖 Generated with Claude Code

…fault market

The header's "Trade" link went to /trade — a redirect page that auto-jumps
into SOL-PERP or the highest-volume market. So clicking "Trade" dropped users
straight into one arbitrary market (e.g. a brand-new low-volume one) instead of
letting them choose. Point it at /markets (the full markets browser) so "Trade"
opens the list and the user picks the market to open in the terminal.

Applied to both the desktop CTA and the mobile menu link. The tab stays
highlighted across the whole trade flow — active on /markets (browser) and
/trade/:slab (terminal). The /trade redirect route is left intact for direct
hits and old links.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@0x-SquidSol
0x-SquidSol requested a review from dcccrypto as a code owner July 29, 2026 14:40
@vercel

vercel Bot commented Jul 29, 2026

Copy link
Copy Markdown

@0x-SquidSol is attempting to deploy a commit to the Khubair Nasir's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c2c6af6e-ab05-4e30-b450-02347520f949

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant