fix(nav): "Trade" opens the markets browser instead of one default market - #2461
fix(nav): "Trade" opens the markets browser instead of one default market#24610x-SquidSol wants to merge 1 commit into
Conversation
…fault market The header's "Trade" link went to /trade — a redirect page that auto-jumps into SOL-PERP or the highest-volume market. So clicking "Trade" dropped users straight into one arbitrary market (e.g. a brand-new low-volume one) instead of letting them choose. Point it at /markets (the full markets browser) so "Trade" opens the list and the user picks the market to open in the terminal. Applied to both the desktop CTA and the mobile menu link. The tab stays highlighted across the whole trade flow — active on /markets (browser) and /trade/:slab (terminal). The /trade redirect route is left intact for direct hits and old links. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
@0x-SquidSol is attempting to deploy a commit to the Khubair Nasir's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
The header's Trade button linked to
/trade— a redirect page that auto-jumps into SOL-PERP or the highest-volume market. So clicking "Trade" dropped users straight into one arbitrary market (often a brand-new, low-volume one) instead of letting them choose which to trade.Fix
Point the "Trade" nav link at
/markets(the full markets browser) so it opens the list and the user picks the market to open in the terminal./markets(browser) and/trade/:slab(terminal).aria-labelupdated ("Trade terminal" → "Trade — browse all markets") to match the destination./traderedirect route is left intact for direct hits and old links.Testing
tsc --noEmitclean.hrefis/markets; clicking it from an app page lands on/markets;/marketsstays put (no redirect) and lists the markets. Screenshot below.🤖 Generated with Claude Code