Skip to content

chore(tests): remove 12 tests orphaned by the Phase A feature removal (playground suite: 87 failures -> 61) - #2457

Closed
dcccrypto wants to merge 1 commit into
playgroundfrom
chore/remove-phase-a-orphaned-tests
Closed

chore(tests): remove 12 tests orphaned by the Phase A feature removal (playground suite: 87 failures -> 61)#2457
dcccrypto wants to merge 1 commit into
playgroundfrom
chore/remove-phase-a-orphaned-tests

Conversation

@dcccrypto

Copy link
Copy Markdown
Owner

What

Phase A (7f5b5121, "cut marketing cruft, lock devnet, decouple Supabase") deliberately removed the waitlist / launch / guide / bugs / ideas / applications routes and lib/waitlist/, but left 12 test files behind. Every one imports source that no longer exists, so they fail at import/collection time and assert nothing.

test file(s) imports (deleted)
bugs-proxy, bugs-trusted-client-ip app/api/bugs/route
launch-invalid-json-guard app/api/launch/route
trusted-ip-rate-limit-headers app/api/ideas, app/api/applications
waitlist-signup-{bot-ua,ip,shape} app/api/waitlist/signup/route
Guide app/guide/page
waitlist-{client-ip,disposable-domains,referral-code,turnstile} lib/waitlist/*

The removal was explicit — the Phase A commit body lists each of these paths under "Remove API routes: applications, ideas, launch, bugs … Remove lib/waitlist/". Only the tests were missed.

Why now

These are not flaky or newly broken — they have been failing since Phase A. They are invisible because no test job actually gates playground (see #2447: the Merge Gate's dependencies are permanently skipped and the gate passes anyway).

Verification (measured, not asserted)

Full vitest run on app/:

state failed tests failed files
playground (fbfaec8) alone 87 27
+ this PR 61 15
+ this PR + open test-repair PRs (#2451 #2452 #2453 #2455 #2456) 0 0 (2803 passed)

The 61 that remain after this PR are exactly the failures those open PRs repair; with all of them merged the playground suite is fully green.

Risk

None to product code — this deletes only test files whose module-under-test does not exist. They provide zero coverage today (they cannot import). If any of these features returns, its tests return with it via git history.

🤖 Generated with Claude Code

Phase A (7f5b512, "cut marketing cruft, lock devnet, decouple Supabase")
deliberately removed the waitlist/launch/guide/bugs/ideas/applications routes
and lib/waitlist/, but left their test files behind. All 12 reference source
that no longer exists, so they fail at import/collection and assert nothing:

  bugs-proxy, bugs-trusted-client-ip        -> app/api/bugs/route
  launch-invalid-json-guard                 -> app/api/launch/route
  trusted-ip-rate-limit-headers             -> app/api/ideas, app/api/applications
  waitlist-signup-{bot-ua,ip,shape}         -> app/api/waitlist/signup/route
  Guide                                     -> app/guide/page
  waitlist-{client-ip,disposable-domains,referral-code,turnstile} -> lib/waitlist/*

They provide zero coverage (they cannot import the module under test), and they
are the entire remainder of playground's failing suite once the open test-repair
PRs land. Verified: full suite on playground goes 87 failed -> 61 failed, and the
61 are exactly the failures the open PRs (#2451/#2452/#2453/#2455/#2456) repair.

If any of these features returns, its tests return with it via git history.
@vercel

vercel Bot commented Jul 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
percolator-launch Ready Ready Preview, Comment Jul 24, 2026 4:45pm
percolator-mainnet Ready Ready Preview, Comment Jul 24, 2026 4:45pm
percolator-playground Ready Ready Preview, Comment Jul 24, 2026 4:45pm

Request Review

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2a8d52ac-b8fd-49eb-a3dc-e94403169317

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-phase-a-orphaned-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dcccrypto

Copy link
Copy Markdown
Owner Author

Closing as superseded — this landed upstream independently.

The test-maintenance batch merged into playground (now 8bab3ced) fixed the 12 tests orphaned by the Phase A feature removal in 7817632 and 5d6f715.

Verified on the current base rather than assumed:

  • I ran the full suite on 8bab3ced alone. It is down to 14 failures / 4 files, and none of them are in this PR's target files — they pass on the base as-is.
  • Re-checked specifically for this PR's scope: nothing left for it to fix.
  • This branch now conflicts with playground for the same reason: upstream edited the very files it touches.

Rebasing it would produce a no-op at best, so closing rather than leaving a stale PR in the queue.

For what it's worth the remaining 14 failures are covered by the three PRs I'm keeping open: #2451 (useWallet + ConnectButton, 7), #2459 (Header nav, 4), #2458 (Portfolio PORT-007, 1). With those three stacked the suite is 2823 passed, 0 failed.

@dcccrypto dcccrypto closed this Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant