chore(tests): remove 12 tests orphaned by the Phase A feature removal (playground suite: 87 failures -> 61) - #2457
Conversation
Phase A (7f5b512, "cut marketing cruft, lock devnet, decouple Supabase") deliberately removed the waitlist/launch/guide/bugs/ideas/applications routes and lib/waitlist/, but left their test files behind. All 12 reference source that no longer exists, so they fail at import/collection and assert nothing: bugs-proxy, bugs-trusted-client-ip -> app/api/bugs/route launch-invalid-json-guard -> app/api/launch/route trusted-ip-rate-limit-headers -> app/api/ideas, app/api/applications waitlist-signup-{bot-ua,ip,shape} -> app/api/waitlist/signup/route Guide -> app/guide/page waitlist-{client-ip,disposable-domains,referral-code,turnstile} -> lib/waitlist/* They provide zero coverage (they cannot import the module under test), and they are the entire remainder of playground's failing suite once the open test-repair PRs land. Verified: full suite on playground goes 87 failed -> 61 failed, and the 61 are exactly the failures the open PRs (#2451/#2452/#2453/#2455/#2456) repair. If any of these features returns, its tests return with it via git history.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing as superseded — this landed upstream independently. The test-maintenance batch merged into Verified on the current base rather than assumed:
Rebasing it would produce a no-op at best, so closing rather than leaving a stale PR in the queue. For what it's worth the remaining 14 failures are covered by the three PRs I'm keeping open: #2451 (useWallet + ConnectButton, 7), #2459 (Header nav, 4), #2458 (Portfolio PORT-007, 1). With those three stacked the suite is 2823 passed, 0 failed. |
What
Phase A (
7f5b5121, "cut marketing cruft, lock devnet, decouple Supabase") deliberately removed the waitlist / launch / guide / bugs / ideas / applications routes andlib/waitlist/, but left 12 test files behind. Every one imports source that no longer exists, so they fail at import/collection time and assert nothing.bugs-proxy,bugs-trusted-client-ipapp/api/bugs/routelaunch-invalid-json-guardapp/api/launch/routetrusted-ip-rate-limit-headersapp/api/ideas,app/api/applicationswaitlist-signup-{bot-ua,ip,shape}app/api/waitlist/signup/routeGuideapp/guide/pagewaitlist-{client-ip,disposable-domains,referral-code,turnstile}lib/waitlist/*The removal was explicit — the Phase A commit body lists each of these paths under "Remove API routes: applications, ideas, launch, bugs … Remove lib/waitlist/". Only the tests were missed.
Why now
These are not flaky or newly broken — they have been failing since Phase A. They are invisible because no test job actually gates
playground(see #2447: the Merge Gate's dependencies are permanently skipped and the gate passes anyway).Verification (measured, not asserted)
Full
vitest runonapp/:playground(fbfaec8) aloneThe 61 that remain after this PR are exactly the failures those open PRs repair; with all of them merged the playground suite is fully green.
Risk
None to product code — this deletes only test files whose module-under-test does not exist. They provide zero coverage today (they cannot import). If any of these features returns, its tests return with it via git history.
🤖 Generated with Claude Code