Skip to content

904 javadoc param return gaps - #906

Merged
jeffjensen merged 2 commits into
mainfrom
904-javadoc-param-return-gaps
Aug 4, 2026
Merged

jeffjensen merged 2 commits into
mainfrom
904-javadoc-param-return-gaps

Conversation

@jeffjensen

@jeffjensen jeffjensen commented Aug 4, 2026

Copy link
Copy Markdown
Member

Summary by Sourcery

Complete and standardize Javadoc across the main source tree, adding missing descriptions and tags and aligning documentation with behavior, while updating build configuration to run stricter Javadoc checks and recording the change in the changelog.

Enhancements:

  • Improve and complete Javadoc across the codebase, adding missing descriptions and tags for parameters, return values, and exceptions.
  • Refine public API documentation for assertion, dataset, database, Ant task, and utility classes to better describe behavior and usage.

Build:

  • Configure the Maven Javadoc plugin to enable doclint while suppressing only missing-description warnings.

Documentation:

  • Document the Javadoc cleanup work and doclint configuration in the project changelog.

Iterated "mvnw javadoc:aggregate-no-fork" across 17 rounds (doclint caps
displayed warnings at ~100 per invocation) until it reported zero
warnings: missing one-sentence summaries on tag-only doc blocks, missing
or description-less @param/@return/@throws tags, explicit default
constructors for classes relying on an undocumented implicit one, and
missing field/method comments including on Serializable classes' private
members that doclint checks regardless of visibility.

Test source warnings, never previously held to any doclint standard,
are tracked separately.

Refs: 904
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @jeffjensen, your pull request is larger than the review limit of 500000 diff characters

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Too many files!

This PR contains 287 files, which is 187 over the limit of 100.

To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch.

Upgrade to a paid plan to raise the limit.

This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e5c59c72-6b27-4332-b9bb-96daa89d97b1

📥 Commits

Reviewing files that changed from the base of the PR and between 223a175 and 40b58ea.

📒 Files selected for processing (287)
  • pom.xml
  • src/changes/changes.xml
  • src/main/java/org/dbunit/AbstractDatabaseTester.java
  • src/main/java/org/dbunit/Assertion.java
  • src/main/java/org/dbunit/DBTestCase.java
  • src/main/java/org/dbunit/DataSourceBasedDBTestCase.java
  • src/main/java/org/dbunit/DatabaseTestCase.java
  • src/main/java/org/dbunit/DatabaseUnitException.java
  • src/main/java/org/dbunit/DatabaseUnitRuntimeException.java
  • src/main/java/org/dbunit/DefaultExpectedDataSetAndVerifyTableDefinitionVerifier.java
  • src/main/java/org/dbunit/DefaultOperationListener.java
  • src/main/java/org/dbunit/DefaultPrepAndExpectedTestCase.java
  • src/main/java/org/dbunit/ExpectedDataSetAndVerifyTableDefinitionVerifier.java
  • src/main/java/org/dbunit/JdbcBasedDBTestCase.java
  • src/main/java/org/dbunit/JndiBasedDBTestCase.java
  • src/main/java/org/dbunit/PrepAndExpectedTestCase.java
  • src/main/java/org/dbunit/PrepAndExpectedTestCaseSteps.java
  • src/main/java/org/dbunit/PropertiesBasedJdbcDatabaseTester.java
  • src/main/java/org/dbunit/VerifyTableDefinition.java
  • src/main/java/org/dbunit/ant/AbstractStep.java
  • src/main/java/org/dbunit/ant/Compare.java
  • src/main/java/org/dbunit/ant/DbConfig.java
  • src/main/java/org/dbunit/ant/DbUnitTask.java
  • src/main/java/org/dbunit/ant/DbUnitTaskStep.java
  • src/main/java/org/dbunit/ant/Export.java
  • src/main/java/org/dbunit/ant/Operation.java
  • src/main/java/org/dbunit/ant/Query.java
  • src/main/java/org/dbunit/ant/QuerySet.java
  • src/main/java/org/dbunit/ant/Table.java
  • src/main/java/org/dbunit/assertion/DbAssertionFailedError.java
  • src/main/java/org/dbunit/assertion/DbComparisonFailure.java
  • src/main/java/org/dbunit/assertion/DbUnitAssert.java
  • src/main/java/org/dbunit/assertion/DbUnitAssertBase.java
  • src/main/java/org/dbunit/assertion/DbUnitValueComparerAssert.java
  • src/main/java/org/dbunit/assertion/DefaultFailureHandler.java
  • src/main/java/org/dbunit/assertion/DiffCollectingFailureHandler.java
  • src/main/java/org/dbunit/assertion/Difference.java
  • src/main/java/org/dbunit/assertion/FailureFactory.java
  • src/main/java/org/dbunit/assertion/FailureHandler.java
  • src/main/java/org/dbunit/assertion/JUnitFailureFactory.java
  • src/main/java/org/dbunit/assertion/SimpleAssert.java
  • src/main/java/org/dbunit/assertion/comparer/value/ConditionalSelectorMultiValueComparer.java
  • src/main/java/org/dbunit/assertion/comparer/value/ConditionalSetBiValueComparer.java
  • src/main/java/org/dbunit/assertion/comparer/value/DefaultValueComparerDefaults.java
  • src/main/java/org/dbunit/assertion/comparer/value/IsActualContainingExpectedStringValueComparer.java
  • src/main/java/org/dbunit/assertion/comparer/value/IsActualEqualToExpectedValueComparer.java
  • src/main/java/org/dbunit/assertion/comparer/value/IsActualEqualToExpectedWithEmptyFailMessageValueComparer.java
  • src/main/java/org/dbunit/assertion/comparer/value/IsActualGreaterThanExpectedValueComparer.java
  • src/main/java/org/dbunit/assertion/comparer/value/IsActualGreaterThanExpectedWithIgnoreMillisValueComparer.java
  • src/main/java/org/dbunit/assertion/comparer/value/IsActualGreaterThanOrEqualToExpectedValueComparer.java
  • src/main/java/org/dbunit/assertion/comparer/value/IsActualGreaterThanOrEqualToExpectedWithIgnoreMillisValueComparer.java
  • src/main/java/org/dbunit/assertion/comparer/value/IsActualLessThanExpectedValueComparer.java
  • src/main/java/org/dbunit/assertion/comparer/value/IsActualLessThanOrEqualToExpectedValueComparer.java
  • src/main/java/org/dbunit/assertion/comparer/value/IsActualNotEqualToExpectedValueComparer.java
  • src/main/java/org/dbunit/assertion/comparer/value/IsActualNotNullValueComparer.java
  • src/main/java/org/dbunit/assertion/comparer/value/IsActualNullValueComparer.java
  • src/main/java/org/dbunit/assertion/comparer/value/IsActualWithinToleranceOfExpectedTimestampValueComparer.java
  • src/main/java/org/dbunit/assertion/comparer/value/NeverFailsValueComparer.java
  • src/main/java/org/dbunit/assertion/comparer/value/TimestampIgnoreMillisValueComparerBase.java
  • src/main/java/org/dbunit/assertion/comparer/value/ValueComparer.java
  • src/main/java/org/dbunit/assertion/comparer/value/ValueComparerBase.java
  • src/main/java/org/dbunit/assertion/comparer/value/ValueComparerDefaults.java
  • src/main/java/org/dbunit/assertion/comparer/value/ValueComparerSelector.java
  • src/main/java/org/dbunit/assertion/comparer/value/ValueComparerTemplateBase.java
  • src/main/java/org/dbunit/assertion/comparer/value/ValueComparers.java
  • src/main/java/org/dbunit/assertion/comparer/value/ValueFactory.java
  • src/main/java/org/dbunit/assertion/comparer/value/builder/ColumnValueComparerMapBuilder.java
  • src/main/java/org/dbunit/assertion/comparer/value/builder/TableColumnValueComparerMapBuilder.java
  • src/main/java/org/dbunit/assertion/comparer/value/verifier/DefaultVerifyTableDefinitionVerifier.java
  • src/main/java/org/dbunit/assertion/comparer/value/verifier/VerifyTableDefinitionVerifier.java
  • src/main/java/org/dbunit/database/AbstractResultSetTable.java
  • src/main/java/org/dbunit/database/AmbiguousTableNameException.java
  • src/main/java/org/dbunit/database/CachedResultSetTable.java
  • src/main/java/org/dbunit/database/CyclicTablesDependencyException.java
  • src/main/java/org/dbunit/database/DatabaseConfig.java
  • src/main/java/org/dbunit/database/DatabaseConnection.java
  • src/main/java/org/dbunit/database/DatabaseDataSet.java
  • src/main/java/org/dbunit/database/DatabaseDataSourceConnection.java
  • src/main/java/org/dbunit/database/DatabaseSequenceFilter.java
  • src/main/java/org/dbunit/database/DatabaseTableIterator.java
  • src/main/java/org/dbunit/database/DatabaseTableMetaData.java
  • src/main/java/org/dbunit/database/ForwardOnlyResultSetTable.java
  • src/main/java/org/dbunit/database/ForwardOnlyResultSetTableFactory.java
  • src/main/java/org/dbunit/database/IMetadataHandler.java
  • src/main/java/org/dbunit/database/IResultSetTable.java
  • src/main/java/org/dbunit/database/IResultSetTableFactory.java
  • src/main/java/org/dbunit/database/PrimaryKeyFilter.java
  • src/main/java/org/dbunit/database/QueryDataSet.java
  • src/main/java/org/dbunit/database/QueryTableIterator.java
  • src/main/java/org/dbunit/database/ResultSetTableMetaData.java
  • src/main/java/org/dbunit/database/ScrollableResultSetTable.java
  • src/main/java/org/dbunit/database/search/AbstractMetaDataBasedSearchCallback.java
  • src/main/java/org/dbunit/database/search/ExportedKeysSearchCallback.java
  • src/main/java/org/dbunit/database/search/FKRelationshipEdge.java
  • src/main/java/org/dbunit/database/search/ImportedAndExportedKeysSearchCallback.java
  • src/main/java/org/dbunit/database/search/ImportedKeysSearchCallback.java
  • src/main/java/org/dbunit/database/search/TablesDependencyHelper.java
  • src/main/java/org/dbunit/database/statement/AbstractPreparedBatchStatement.java
  • src/main/java/org/dbunit/database/statement/AbstractStatementFactory.java
  • src/main/java/org/dbunit/database/statement/AutomaticPreparedBatchStatement.java
  • src/main/java/org/dbunit/database/statement/IPreparedBatchStatement.java
  • src/main/java/org/dbunit/database/statement/IStatementFactory.java
  • src/main/java/org/dbunit/database/statement/PreparedStatementFactory.java
  • src/main/java/org/dbunit/database/statement/SimplePreparedStatement.java
  • src/main/java/org/dbunit/database/statement/StatementFactory.java
  • src/main/java/org/dbunit/dataset/AbstractTable.java
  • src/main/java/org/dbunit/dataset/AbstractTableMetaData.java
  • src/main/java/org/dbunit/dataset/CachedDataSet.java
  • src/main/java/org/dbunit/dataset/CachedTable.java
  • src/main/java/org/dbunit/dataset/CaseInsensitiveDataSet.java
  • src/main/java/org/dbunit/dataset/CaseInsensitiveTable.java
  • src/main/java/org/dbunit/dataset/Column.java
  • src/main/java/org/dbunit/dataset/ColumnFilterTable.java
  • src/main/java/org/dbunit/dataset/Columns.java
  • src/main/java/org/dbunit/dataset/CompositeDataSet.java
  • src/main/java/org/dbunit/dataset/CompositeTable.java
  • src/main/java/org/dbunit/dataset/DataSetException.java
  • src/main/java/org/dbunit/dataset/DataSetUtils.java
  • src/main/java/org/dbunit/dataset/DefaultDataSet.java
  • src/main/java/org/dbunit/dataset/DefaultTable.java
  • src/main/java/org/dbunit/dataset/DefaultTableIterator.java
  • src/main/java/org/dbunit/dataset/DefaultTableMetaData.java
  • src/main/java/org/dbunit/dataset/FilteredDataSet.java
  • src/main/java/org/dbunit/dataset/FilteredTableMetaData.java
  • src/main/java/org/dbunit/dataset/ForwardOnlyDataSet.java
  • src/main/java/org/dbunit/dataset/ForwardOnlyTable.java
  • src/main/java/org/dbunit/dataset/IRowValueProvider.java
  • src/main/java/org/dbunit/dataset/ITable.java
  • src/main/java/org/dbunit/dataset/ITableIterator.java
  • src/main/java/org/dbunit/dataset/LowerCaseDataSet.java
  • src/main/java/org/dbunit/dataset/LowerCaseTableMetaData.java
  • src/main/java/org/dbunit/dataset/NoPrimaryKeyException.java
  • src/main/java/org/dbunit/dataset/NoSuchColumnException.java
  • src/main/java/org/dbunit/dataset/NoSuchTableException.java
  • src/main/java/org/dbunit/dataset/OrderedTableNameMap.java
  • src/main/java/org/dbunit/dataset/ReplacementDataSet.java
  • src/main/java/org/dbunit/dataset/ReplacementTable.java
  • src/main/java/org/dbunit/dataset/RowFilterTable.java
  • src/main/java/org/dbunit/dataset/RowOutOfBoundsException.java
  • src/main/java/org/dbunit/dataset/SortedDataSet.java
  • src/main/java/org/dbunit/dataset/SortedTable.java
  • src/main/java/org/dbunit/dataset/TableDecoratorDataSet.java
  • src/main/java/org/dbunit/dataset/common/handlers/AbstractPipelineComponent.java
  • src/main/java/org/dbunit/dataset/common/handlers/AllHandler.java
  • src/main/java/org/dbunit/dataset/common/handlers/EnforceHandler.java
  • src/main/java/org/dbunit/dataset/common/handlers/EscapeHandler.java
  • src/main/java/org/dbunit/dataset/common/handlers/Handler.java
  • src/main/java/org/dbunit/dataset/common/handlers/Helper.java
  • src/main/java/org/dbunit/dataset/common/handlers/IllegalInputCharacterException.java
  • src/main/java/org/dbunit/dataset/common/handlers/IsAlnumHandler.java
  • src/main/java/org/dbunit/dataset/common/handlers/NoHandler.java
  • src/main/java/org/dbunit/dataset/common/handlers/Pipeline.java
  • src/main/java/org/dbunit/dataset/common/handlers/PipelineComponent.java
  • src/main/java/org/dbunit/dataset/common/handlers/PipelineConfig.java
  • src/main/java/org/dbunit/dataset/common/handlers/PipelineException.java
  • src/main/java/org/dbunit/dataset/common/handlers/QuoteHandler.java
  • src/main/java/org/dbunit/dataset/common/handlers/SeparatorHandler.java
  • src/main/java/org/dbunit/dataset/common/handlers/TransparentHandler.java
  • src/main/java/org/dbunit/dataset/common/handlers/UnquotedFieldAssembler.java
  • src/main/java/org/dbunit/dataset/common/handlers/WhitespacesHandler.java
  • src/main/java/org/dbunit/dataset/csv/CsvDataSet.java
  • src/main/java/org/dbunit/dataset/csv/CsvDataSetWriter.java
  • src/main/java/org/dbunit/dataset/csv/CsvParser.java
  • src/main/java/org/dbunit/dataset/csv/CsvParserException.java
  • src/main/java/org/dbunit/dataset/csv/CsvParserImpl.java
  • src/main/java/org/dbunit/dataset/csv/CsvProducer.java
  • src/main/java/org/dbunit/dataset/csv/CsvURLDataSet.java
  • src/main/java/org/dbunit/dataset/csv/IllegalCharacterSeen.java
  • src/main/java/org/dbunit/dataset/datatype/AbstractDataType.java
  • src/main/java/org/dbunit/dataset/datatype/BigIntegerDataType.java
  • src/main/java/org/dbunit/dataset/datatype/BinaryStreamDataType.java
  • src/main/java/org/dbunit/dataset/datatype/BlobDataType.java
  • src/main/java/org/dbunit/dataset/datatype/BytesDataType.java
  • src/main/java/org/dbunit/dataset/datatype/ClobDataType.java
  • src/main/java/org/dbunit/dataset/datatype/DataType.java
  • src/main/java/org/dbunit/dataset/datatype/DataTypeException.java
  • src/main/java/org/dbunit/dataset/datatype/DefaultDataTypeFactory.java
  • src/main/java/org/dbunit/dataset/datatype/IDataTypeFactory.java
  • src/main/java/org/dbunit/dataset/datatype/NumberTolerantDataType.java
  • src/main/java/org/dbunit/dataset/datatype/StringDataType.java
  • src/main/java/org/dbunit/dataset/datatype/StringIgnoreCaseDataType.java
  • src/main/java/org/dbunit/dataset/datatype/ToleratedDeltaMap.java
  • src/main/java/org/dbunit/dataset/datatype/TypeCastException.java
  • src/main/java/org/dbunit/dataset/excel/XlsDataSet.java
  • src/main/java/org/dbunit/dataset/excel/XlsDataSetWriter.java
  • src/main/java/org/dbunit/dataset/filter/AbstractTableFilter.java
  • src/main/java/org/dbunit/dataset/filter/DefaultColumnFilter.java
  • src/main/java/org/dbunit/dataset/filter/DefaultTableFilter.java
  • src/main/java/org/dbunit/dataset/filter/ExcludeTableFilter.java
  • src/main/java/org/dbunit/dataset/filter/GeneratedColumnFilter.java
  • src/main/java/org/dbunit/dataset/filter/ITableFilter.java
  • src/main/java/org/dbunit/dataset/filter/ITableFilterSimple.java
  • src/main/java/org/dbunit/dataset/filter/IncludeTableFilter.java
  • src/main/java/org/dbunit/dataset/filter/SequenceTableFilter.java
  • src/main/java/org/dbunit/dataset/filter/SequenceTableIterator.java
  • src/main/java/org/dbunit/dataset/sqlloader/SqlLoaderControlParser.java
  • src/main/java/org/dbunit/dataset/sqlloader/SqlLoaderControlParserImpl.java
  • src/main/java/org/dbunit/dataset/sqlloader/SqlLoaderControlProducer.java
  • src/main/java/org/dbunit/dataset/stream/BufferedConsumer.java
  • src/main/java/org/dbunit/dataset/stream/DataSetProducerAdapter.java
  • src/main/java/org/dbunit/dataset/stream/DefaultConsumer.java
  • src/main/java/org/dbunit/dataset/stream/IDataSetConsumer.java
  • src/main/java/org/dbunit/dataset/stream/IDataSetProducer.java
  • src/main/java/org/dbunit/dataset/stream/StreamingDataSet.java
  • src/main/java/org/dbunit/dataset/stream/StreamingIterator.java
  • src/main/java/org/dbunit/dataset/xml/FlatDtdDataSet.java
  • src/main/java/org/dbunit/dataset/xml/FlatDtdProducer.java
  • src/main/java/org/dbunit/dataset/xml/FlatDtdWriter.java
  • src/main/java/org/dbunit/dataset/xml/FlatXmlDataSet.java
  • src/main/java/org/dbunit/dataset/xml/FlatXmlDataSetBuilder.java
  • src/main/java/org/dbunit/dataset/xml/FlatXmlProducer.java
  • src/main/java/org/dbunit/dataset/xml/FlatXmlWriter.java
  • src/main/java/org/dbunit/dataset/xml/XmlDataSet.java
  • src/main/java/org/dbunit/dataset/xml/XmlDataSetWriter.java
  • src/main/java/org/dbunit/dataset/xml/XmlProducer.java
  • src/main/java/org/dbunit/dataset/yaml/YamlDataSet.java
  • src/main/java/org/dbunit/dataset/yaml/YamlProducer.java
  • src/main/java/org/dbunit/ext/db2/Db2Connection.java
  • src/main/java/org/dbunit/ext/db2/Db2MetadataHandler.java
  • src/main/java/org/dbunit/ext/h2/H2Connection.java
  • src/main/java/org/dbunit/ext/hsqldb/HsqldbConnection.java
  • src/main/java/org/dbunit/ext/mckoi/MckoiConnection.java
  • src/main/java/org/dbunit/ext/mckoi/MckoiDataTypeFactory.java
  • src/main/java/org/dbunit/ext/mssql/DateTimeOffsetType.java
  • src/main/java/org/dbunit/ext/mssql/InsertIdentityOperation.java
  • src/main/java/org/dbunit/ext/mssql/MsSqlConnection.java
  • src/main/java/org/dbunit/ext/mssql/MsSqlDataTypeFactory.java
  • src/main/java/org/dbunit/ext/mssql/UniqueIdentifierType.java
  • src/main/java/org/dbunit/ext/mysql/MySqlConnection.java
  • src/main/java/org/dbunit/ext/mysql/MySqlDataTypeFactory.java
  • src/main/java/org/dbunit/ext/netezza/NetezzaDataTypeFactory.java
  • src/main/java/org/dbunit/ext/netezza/NetezzaMetadataHandler.java
  • src/main/java/org/dbunit/ext/oracle/Oracle10DataTypeFactory.java
  • src/main/java/org/dbunit/ext/oracle/OracleBlobDataType.java
  • src/main/java/org/dbunit/ext/oracle/OracleClobDataType.java
  • src/main/java/org/dbunit/ext/oracle/OracleConnection.java
  • src/main/java/org/dbunit/ext/oracle/OracleDataTypeFactory.java
  • src/main/java/org/dbunit/ext/oracle/OracleSdoElemInfoArray.java
  • src/main/java/org/dbunit/ext/oracle/OracleSdoGeometry.java
  • src/main/java/org/dbunit/ext/oracle/OracleSdoOrdinateArray.java
  • src/main/java/org/dbunit/ext/oracle/OracleSdoPointType.java
  • src/main/java/org/dbunit/ext/postgresql/CitextType.java
  • src/main/java/org/dbunit/ext/postgresql/GenericEnumType.java
  • src/main/java/org/dbunit/ext/postgresql/GeometryType.java
  • src/main/java/org/dbunit/ext/postgresql/InetType.java
  • src/main/java/org/dbunit/ext/postgresql/IntervalType.java
  • src/main/java/org/dbunit/ext/postgresql/PostgreSQLOidDataType.java
  • src/main/java/org/dbunit/ext/postgresql/PostgresqlDataTypeFactory.java
  • src/main/java/org/dbunit/ext/postgresql/UuidType.java
  • src/main/java/org/dbunit/operation/AbstractOperation.java
  • src/main/java/org/dbunit/operation/CloseConnectionOperation.java
  • src/main/java/org/dbunit/operation/CompositeOperation.java
  • src/main/java/org/dbunit/operation/DatabaseOperation.java
  • src/main/java/org/dbunit/operation/DeleteAllOperation.java
  • src/main/java/org/dbunit/operation/ExclusiveTransactionException.java
  • src/main/java/org/dbunit/operation/OperationData.java
  • src/main/java/org/dbunit/operation/TransactionOperation.java
  • src/main/java/org/dbunit/util/Base64.java
  • src/main/java/org/dbunit/util/FileHelper.java
  • src/main/java/org/dbunit/util/QualifiedTableName.java
  • src/main/java/org/dbunit/util/RelativeDateTimeParser.java
  • src/main/java/org/dbunit/util/SQLHelper.java
  • src/main/java/org/dbunit/util/TableFormatter.java
  • src/main/java/org/dbunit/util/concurrent/BoundedBuffer.java
  • src/main/java/org/dbunit/util/concurrent/BoundedLinkedQueue.java
  • src/main/java/org/dbunit/util/concurrent/Channel.java
  • src/main/java/org/dbunit/util/concurrent/DefaultChannelCapacity.java
  • src/main/java/org/dbunit/util/concurrent/Executor.java
  • src/main/java/org/dbunit/util/concurrent/LinkedNode.java
  • src/main/java/org/dbunit/util/concurrent/LinkedQueue.java
  • src/main/java/org/dbunit/util/concurrent/PropertyChangeMulticaster.java
  • src/main/java/org/dbunit/util/concurrent/Semaphore.java
  • src/main/java/org/dbunit/util/concurrent/SemaphoreControlledChannel.java
  • src/main/java/org/dbunit/util/concurrent/Slot.java
  • src/main/java/org/dbunit/util/concurrent/Sync.java
  • src/main/java/org/dbunit/util/concurrent/SynchronizedInt.java
  • src/main/java/org/dbunit/util/concurrent/SynchronizedVariable.java
  • src/main/java/org/dbunit/util/concurrent/SynchronousChannel.java
  • src/main/java/org/dbunit/util/concurrent/TimeoutException.java
  • src/main/java/org/dbunit/util/search/AbstractExcludeNodesSearchCallback.java
  • src/main/java/org/dbunit/util/search/AbstractIncludeNodesSearchCallback.java
  • src/main/java/org/dbunit/util/search/AbstractNodesFilterSearchCallback.java
  • src/main/java/org/dbunit/util/search/DepthFirstSearch.java
  • src/main/java/org/dbunit/util/search/Edge.java
  • src/main/java/org/dbunit/util/search/SearchException.java
  • src/main/java/org/dbunit/util/xml/XmlWriter.java
  • src/test/java/org/dbunit/DatabaseEnvironment.java

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai

sourcery-ai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Reviewer's Guide

Adds and enriches Javadoc across assertion, dataset, XML/CSV/excel, concurrency, and database-related classes, and wires doclint configuration into the Maven Javadoc plugin, improving documentation quality without changing runtime behavior.

File-Level Changes

Change Details Files
Document behavior and parameters of DbUnit assertion, comparison, and value-comparer APIs.
  • Expanded Javadoc on DbUnitAssertBase comparison helpers, failure handler selection, and value-comparer defaults.
  • Clarified assertion entrypoints in Assertion and DbUnitValueComparerAssert with param/throws descriptions.
  • Documented Difference, DefaultFailureHandler, and related verifier classes, including failure reporting semantics.
src/main/java/org/dbunit/assertion/DbUnitAssertBase.java
src/main/java/org/dbunit/assertion/DbUnitAssert.java
src/main/java/org/dbunit/assertion/DbUnitValueComparerAssert.java
src/main/java/org/dbunit/assertion/Assertion.java
src/main/java/org/dbunit/assertion/Difference.java
src/main/java/org/dbunit/assertion/DefaultFailureHandler.java
src/main/java/org/dbunit/assertion/JUnitFailureFactory.java
src/main/java/org/dbunit/assertion/SimpleAssert.java
src/main/java/org/dbunit/assertion/DiffCollectingFailureHandler.java
src/main/java/org/dbunit/assertion/DbAssertionFailedError.java
src/main/java/org/dbunit/assertion/comparer/value/*.java
src/main/java/org/dbunit/assertion/comparer/value/builder/*.java
src/main/java/org/dbunit/assertion/comparer/value/verifier/*.java
Improve Javadoc for dataset, table, filter, and streaming/producer/consumer types.
  • Described constructors and semantics of core dataset and table types (DefaultDataSet, DefaultTable, CompositeDataSet/Table, SortedTable/DataSet, CachedDataSet/Table).
  • Documented column/metadata utilities (Column, Columns, TableFormatter, ColumnFilterTable, FilteredTableMetaData, DefaultTableFilter, Include/Exclude filters).
  • Clarified streaming and buffering behavior for IDataSetProducer/IDataSetConsumer, StreamingDataSet/Iterator, DataSetProducerAdapter, BufferedConsumer, ForwardOnlyDataSet/Table, RowFilterTable, ReplacementDataSet/Table, TableDecoratorDataSet.
src/main/java/org/dbunit/dataset/*.java
src/main/java/org/dbunit/dataset/filter/*.java
src/main/java/org/dbunit/dataset/stream/*.java
src/main/java/org/dbunit/dataset/csv/*.java
src/main/java/org/dbunit/dataset/xml/*.java
src/main/java/org/dbunit/dataset/excel/*.java
src/main/java/org/dbunit/dataset/yaml/*.java
src/main/java/org/dbunit/dataset/sqlloader/*.java
Clarify database connection, metadata, and search helpers, including platform-specific extensions.
  • Added constructor and method documentation for DatabaseConnection, DatabaseDataSourceConnection, DatabaseDataSet, QueryDataSet, DatabaseConfig, and related statement/result-set factories.
  • Explained metadata handler responsibilities and platform quirks (OracleConnection/DataTypeFactory, PostgreSQL/H2/HSQLDB/MySQL/MSSQL/DB2/Netezza connection and datatype/metadata classes).
  • Documented table dependency search helpers (TablesDependencyHelper, PrimaryKeyFilter, depth-first search callbacks, FK relationship edges, cyclic-dependency exception).
src/main/java/org/dbunit/database/*.java
src/main/java/org/dbunit/database/search/*.java
src/main/java/org/dbunit/ext/*/*.java
src/main/java/org/dbunit/util/search/*.java
Add Javadoc for Ant task integration (DbUnitTask and its steps) and test-case helpers.
  • Documented DbUnit Ant task properties and child elements (DbUnitTask, DbConfig, Operation, Compare, Export, Query, QuerySet, AbstractStep).
  • Clarified test harness classes and interfaces (DatabaseTestCase, DBTestCase, JdbcBasedDBTestCase, JndiBasedDBTestCase, DataSourceBasedDBTestCase, DefaultPrepAndExpectedTestCase, PrepAndExpectedTestCase/Steps, ExpectedDataSetAndVerifyTableDefinitionVerifier, VerifyTableDefinition).
src/main/java/org/dbunit/ant/*.java
src/main/java/org/dbunit/DatabaseTestCase.java
src/main/java/org/dbunit/DBTestCase.java
src/main/java/org/dbunit/JdbcBasedDBTestCase.java
src/main/java/org/dbunit/JndiBasedDBTestCase.java
src/main/java/org/dbunit/DataSourceBasedDBTestCase.java
src/main/java/org/dbunit/DefaultPrepAndExpectedTestCase.java
src/main/java/org/dbunit/PrepAndExpectedTestCase.java
src/main/java/org/dbunit/PrepAndExpectedTestCaseSteps.java
src/main/java/org/dbunit/ExpectedDataSetAndVerifyTableDefinitionVerifier.java
src/main/java/org/dbunit/VerifyTableDefinition.java
Improve documentation for concurrency utilities and CSV parsing pipeline.
  • Added field, constructor, and method Javadoc to SynchronizedInt, SynchronizedVariable, LinkedQueue, BoundedBuffer/LinkedQueue, Semaphore/SemaphoreControlledChannel, Slot, SynchronousChannel, PropertyChangeMulticaster, TimeoutException, Executor, Sync.
  • Documented CSV parsing pipeline components and handlers (Pipeline, PipelineConfig, PipelineComponent, Helper, Handler, Quote/Separator/Escape/All/Whitespace/Transparent/NoHandler, UnquotedFieldAssembler, IsAlnumHandler, EnforceHandler, CsvParser/Impl, SqlLoaderControlParser/Impl, CsvDataSetWriter, CsvProducer).
src/main/java/org/dbunit/util/concurrent/*.java
src/main/java/org/dbunit/dataset/common/handlers/*.java
src/main/java/org/dbunit/dataset/csv/*.java
src/main/java/org/dbunit/dataset/sqlloader/*.java
Configure Maven Javadoc plugin to enable doclint and document the change in the changelog.
  • Added additionalOptions block to the maven-javadoc-plugin to run with -Xdoclint:all,-missing, surfacing style issues without failing on missing tags.
  • Recorded the doclint and Javadoc gap-fix work in changes.xml for release tracking.
pom.xml
src/changes/changes.xml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Adding a no-arg constructor purely to give doclint's default-constructor
check something to attach a comment to adds no real information.
Regretfully, disabling the check also disables the useful missing-Javadoc
checks on real methods, since doclint has no way to suppress only the
default-constructor case.

Refs: 904
@jeffjensen
jeffjensen force-pushed the 904-javadoc-param-return-gaps branch from 14e42f0 to 40b58ea Compare August 4, 2026 02:31
@jeffjensen
jeffjensen merged commit 171f1dd into main Aug 4, 2026
8 of 9 checks passed
@jeffjensen
jeffjensen deleted the 904-javadoc-param-return-gaps branch August 4, 2026 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant