902 fix build warnings errors - #905
Merged
Merged
Conversation
Run a full "mvnw clean install site" and fix everything it surfaced: * Remove the FIXME'd -Xdoclint:none suppression from maven-javadoc-plugin now that issue 886's Javadoc cleanup is done, and fix every doclint warning/error it had been hiding across the main source tree, including missing @param/@return/@throws tags on the core public API (IDatabaseConnection, IDatabaseTester, IDataSet, ITableMetaData, DataType, DatabaseOperation) and invalid HTML throughout Doug Lea's vendored util.concurrent classes. * Fix compiler warnings: a dead compilerVersion parameter, 21 non-varargs calls to varargs methods with an inexact array argument type (several silently mis-formatting SLF4J debug messages), and Surefire/Failsafe's deprecated systemProperties style. * Fix all 54 Checkstyle violations the pinned checkstyle 13.3.0 engine reported once its dependency resolved correctly: missing @author/@Version tags on pre-convention classes and two wildcard imports. Refs: 902 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AvRxjuGT9d2redtnvdnYXV
* anttask/canoo-webtest-example.adoc: promote 4 Step headings from level 2 to level 1, since they follow the document title directly with no enclosing level-1 section. * anttask.adoc: attach the <taskdef> source block to its list item with a `+` continuation so the numbered list doesn't split and restart at 3; convert 5 tables from `!` to `|` cell separators, the correct default that matches every other table in the file. * intro.adoc: backslash-escape 4 standalone "[...]" elision markers so they aren't misparsed as empty AsciiDoc block attribute lists. The remaining "Fallback behaviour for node: admonition/open" warnings are an architectural Doxia Sink limitation (confirmed via Asciidoctor's own docs, and empirically: every admonition/open-block-using page in the site triggers one, not just these), not fixable via content edits. Refs: 902 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AvRxjuGT9d2redtnvdnYXV
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Important Review skippedToo many files! This PR contains 162 files, which is 62 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (162)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.