fix: quote shell variables to prevent injection#271
Open
arijitroy003 wants to merge 1 commit into
Open
Conversation
Unquoted $1 and $2 in base_model_creation.sh and run_test.sh allow shell injection via malformed source/table names or target arguments. Wrap all positional parameters in double quotes.
dosubot
Bot
added
the
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$1,$2) inbash_scripts/base_model_creation.shandrun_test.shwith double quotesDetails
base_model_creation.shuses$1and$2unquoted in both filename construction and the--argsJSON string passed todbt run-operation. A malformed source or table name (e.g. containing$(cmd)or; rm -rf /) would be interpreted by the shell rather than treated as a literal string.run_test.shsimilarly passes$1unquoted to--target, which has the same class of vulnerability.Test plan
--argsJSON structure remains valid with the quote-close-quote-open pattern ('"$1"')