Repository navigation
fix: strengthen collection and helper typing contracts - #310
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collection annotations allowed invalid array indexing and assignments, constrained the wrong side of Block.sum_by, and misrepresented summation results. Preserve array element types through storage and indexing overloads, constrain summable projection results, and include integer zero in empty-sum return types. For example, Block.of("one", "four").sum_by(len) is valid, while assigning a string to TypedArray[int] is rejected by type checking.
Replace unnecessary Any annotations with object, preserve flip's return type, order input type parameters before result types, and remove obsolete ignores and casts. Express Result traversal with typed composition while preserving evaluation order and error precedence. Add runtime regressions, positive and negative typing contracts, and collection reference documentation.
Verification:
.venv/bin/pytest -qandPATH="$PWD/.venv/bin:$PATH" .venv/bin/pre-commit run --all-files.