Repository navigation
fix: preserve result catch signatures without type ignores - #308
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
catchrequired atype: ignorebecause its overloads disagreed with the implementation about keyword-onlyexceptionand the returned callable. Align both calling forms and use a generic decorator protocol withParamSpecto preserve arguments, result payloads, and existing error channels, including stacked decorators.For example, wrapping an
(int) -> intfunction withcatch(exception=ValueError)now retains its integer argument and returnsResult[int, ValueError]; wrapping an existingResult[int, str]function returnsResult[int, str | ValueError]. Incorrect argument types are rejected. Runtime behavior is unchanged.Retain
typing_extensions.TypeVardefaults for Python 3.12 compatibility and document whyNeveris needed to avoid an inferred unknown error channel. Add positive inference, runtime, and negative typing regression coverage.Verification commands:
pre-commit run --all-files --show-diff-on-failure,python -m pytest, andpython scripts/check_docs.py.