Repository navigation
feat!: infer union tags from literal annotations - #303
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Case declarations currently repeat the discriminator string in both the Literal annotation and tag(). Derive the runtime default from the annotation so declarations become
tag: Literal["customer_id"] = tag().Inference runs when the class is declared, including Python 3.14 deferred annotations, without adding work to instance construction. Update built-in cases, documentation, and typing contracts, and document single-case domain types.
Breaking change:
tag("name")is no longer accepted. Replace it withtag()and keep the single-string Literal annotation. Tags remain excluded from constructors and positional patterns.Verification:
uv run pytest -qanduv run pre-commit run --all-files.