Repository navigation
fix: freeze immutable collection backing state - #302
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Block and Map currently allow callers to replace their backing state, and mutating a shared map tree node can change multiple maps. Freeze the collection wrappers and tree nodes, and use slots (including an empty slot declaration on PipeMixin) to remove writable instance dictionaries.
Existing fluent and functional APIs retain shallow immutability: updates produce new collections while contained objects retain their own mutability. Ordinary assignment and deletion of backing fields now raise FrozenInstanceError; code relying on instance dictionaries or dynamic attributes must stop doing so. Copying, pickle round trips, weak references, pattern matching, and existing equality/hash behavior are preserved.
Adds regression coverage for mutation attempts and shared nodes, plus documentation examples explaining the guarantee and deliberate bypasses.
Verification:
just check(lint, strict typing, and full test suite).