Add Appraisals to test against multiple json gem versions

[dblock]

Description

Adds an Appraisal-based test matrix (json-2, json-3) so the existing spec suite can be run against both json < 3.0 (currently supported) and json >= 3.0, to reproduce and track #113.

json 3.0 changed JSON.parse to keyword-only options, dropping the positional options hash form that Faraday's :json response middleware relies on. As a result, any Strava API response parsed through Faraday's JSON middleware fails with:

Faraday::ParsingError: wrong number of arguments (given 2, expected 1)

Changes

• Adds appraisal gem and an Appraisals file defining json-2 and json-3 appraisals.
• Moves rubocop, rubocop-rake, and rubocop-rspec out of the main Gemfile into their own gemfiles/rubocop.gemfile, since rubocop < 1.90 pins json ~> 2.3, which otherwise made it impossible to resolve a Gemfile that also depends on json ~> 3.0.
• Updates the Rakefile default task and .github/workflows/rubocop.yml to use gemfiles/rubocop.gemfile via BUNDLE_GEMFILE.
• Adds an appraisals CI job in .github/workflows/test.yml that runs rake spec against the json-2 gemfile. The json-3 entry is present but commented out since it currently fails CI — it's there so it's easy to re-enable once the underlying incompatibility (tracked in Faraday::ParsingError with json gem >= 3.0 (ArgumentError: wrong number of arguments) #113) is fixed, or to run manually/locally.
• Excludes generated gemfiles/*.gemfile from rubocop and gemfiles/*.gemfile.lock from git.
• Documents the new workflow in CONTRIBUTING.md and CHANGELOG.md.

Verification

Ran locally:

BUNDLE_GEMFILE=gemfiles/json_2.gemfile bundle install
BUNDLE_GEMFILE=gemfiles/json_2.gemfile bundle exec rake spec   # 338 examples, 0 failures

BUNDLE_GEMFILE=gemfiles/json_3.gemfile bundle install
BUNDLE_GEMFILE=gemfiles/json_3.gemfile bundle exec rake spec   # 18 failures reproducing #113

BUNDLE_GEMFILE=gemfiles/rubocop.gemfile bundle install
BUNDLE_GEMFILE=gemfiles/rubocop.gemfile bundle exec rubocop    # no offenses

Related to #113.

[github-actions]

Danger Report

No issues found.

View run