Add live endpoint integration test - #108
Merged
Merged
Conversation
Danger ReportNo issues found. |
dblock
added a commit
that referenced
this pull request
Aug 24, 2026
dblock
changed the title
dblock
force-pushed
the
dblock/revert-api-v3-url
branch
2 times, most recently
from
August 24, 2026 22:01
b624e79 to
66a66eb
Compare
Reverts the default API base URL back to https://www.strava.com/api/v3, since Strava's new https://www.api-v3.strava.com endpoint is not yet live (keeping the revoke/deauthorize change from #102, which is independently valid). Removes a hand-crafted (non-recorded) star_segment.yml VCR cassette. Adds a live (non-mocked) integration test that requests the configured base URL and asserts a real 401 response, to catch regressions of this kind. Wired into a new `rake spec:integration` task (excluded from the default `rake spec`) and a new CI job that runs on every push/PR. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dblock
force-pushed
the
dblock/revert-api-v3-url
branch
from
August 24, 2026 22:02
66a66eb to
5b06fbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
PR #102 prematurely changed the default API base URL to Strava's future endpoint (
https://www.api-v3.strava.com), which won't be live until Strava's developer program cutover (~2026/2027). The current, real, live endpoint is stillhttps://www.strava.com/api/v3. This reverts that base URL change (keeping therevoke/deauthorizechange from #102, which is independently valid) and adds a test to prevent this regressing again.Changes
endpointback tohttps://www.strava.com/api/v3across lib, README, and VCR cassette fixtures.star_segment.ymlVCR cassette.spec/integration/api_endpoint_spec.rb, that requests the configured base URL and asserts a real 401 response, to catch regressions of this kind. Wired into a newrake spec:integrationtask (excluded from the defaultrake spec) and a new CI job that runs on every push/PR.