Gracefully fail on background completion connection issues#1880
Open
rolandwalker wants to merge 1 commit intomainfrom
Open
Gracefully fail on background completion connection issues#1880rolandwalker wants to merge 1 commit intomainfrom
rolandwalker wants to merge 1 commit intomainfrom
Conversation
If we fail to make a connection for background completion refresh, catch the error and return without performing the refresh.
rolandwalker
force-pushed
the
RW/graceful-fail-bg-completion-refresh
branch
from
32ed163 to
3fd150b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If we fail to make a connection for background completion refresh, catch the error and return without performing the refresh.
This issue is happening to me frequently on certain hosts, with the symptom that a noisy trace is dumped into the REPL session.
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).