Skip to content

support ruby 3.1 and keep old versions#15

Open
kritik wants to merge 2 commits into
dball:masterfrom
perfectline:ruby-3.1
Open

support ruby 3.1 and keep old versions#15
kritik wants to merge 2 commits into
dball:masterfrom
perfectline:ruby-3.1

Conversation

@kritik

@kritik kritik commented Mar 14, 2023

Copy link
Copy Markdown

No description provided.

@kritik

kritik commented Mar 14, 2023

Copy link
Copy Markdown
Author

I know about #10. Difference is that my version keeps support for old versions as well

@haseebeqx

haseebeqx commented Apr 8, 2023

Copy link
Copy Markdown

@dball Please merge this. This PR will make this gem support newer versions of ruby.

@ashgkwd

ashgkwd commented May 16, 2024

Copy link
Copy Markdown

I need this PR merged. Can someone please merge it?

I get the following error without this fix.

NameError: uninitialized class variable @@schemes in URI
/Users/ash/.rbenv/versions/3.3.1/lib/ruby/gems/3.3.0/gems/data_uri-0.1.0/lib/data_uri/uri.rb:64:in `<module:URI>'

will-clarke-blacklane pushed a commit to will-clarke-blacklane/data_uri that referenced this pull request Nov 8, 2024
@PikachuEXE

Copy link
Copy Markdown

Planning to release a new gem with similar name just to let people use it with newer uri versions (required by rails 8)
data-uri-ruby#1 to be merged within this month & start releasing first version

@PikachuEXE

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants