Gui2 - Upgrade imhex to latest to fix scaling issues on KDE Wayland#866
Open
the-claw wants to merge 4 commits into
Open
Gui2 - Upgrade imhex to latest to fix scaling issues on KDE Wayland#866the-claw wants to merge 4 commits into
the-claw wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ImHex UI gets double-scaled on Wayland compositors due to a bug in imgui which has been recently resolved in both imgui and ImHex, so to obtain the fix I have updated ImHex to the latest version and fixed up the builds and fluxengine gui2 sources.
This required also forking the
davidgiven/ImHexrepository to re-apply the fluxengine-specific patches, and so thedep/build.pyscript in this PR currently clones from my fork. I've made another PR for thedavidgiven/ImHexfork to update it to the latest version of ImHex. Once that's merged, thedep/build.pyscript will need updating to point todavidgiven/ImHexagain.Note that I have only tested these builds on Linux. I am unable to test on Windows or MacOS at this time.