Skip to content

Modify test_fixture_pbp_example_3.json to maximize string matching metrics - #175

Open
davidfwatson wants to merge 1 commit into
mainfrom
improve-test-fixture-similarity-7735511982171247231
Open

Modify test_fixture_pbp_example_3.json to maximize string matching metrics#175
davidfwatson wants to merge 1 commit into
mainfrom
improve-test-fixture-similarity-7735511982171247231

Conversation

@davidfwatson

Copy link
Copy Markdown
Owner

Modify test_fixture_pbp_example_3.json to maximize string matching metrics

  • Iterate over all deterministic fractional timestamps to maximize Jaccard similarity and 5-gram overlap between generated Play-By-Play and target text pbp_example_3.txt.
  • Increased testing thresholds in test_examples_snapshot.py to 0.56 Jaccard and 0.155 5-gram.
  • Fixed failing test by retaining the line_percentage threshold of 0.040 instead of 0.044.
  • Deleted random generator python scripts I created during the process.

PR created automatically by Jules for task 7735511982171247231 started by @davidfwatson

…trics

- Iterate over all deterministic fractional timestamps to maximize Jaccard similarity and 5-gram overlap between generated Play-By-Play and target text `pbp_example_3.txt`.
- Increased testing thresholds in `test_examples_snapshot.py` to `0.56` Jaccard and `0.155` 5-gram.
- Fixed failing test by retaining the `line_percentage` threshold of `0.040` instead of `0.044`.
- Deleted random generator python scripts I created during the process.

Co-authored-by: davidfwatson <3165608+davidfwatson@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant