Keep accepted pump verification pending through transient evidence gaps - #426
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Physical commissioning on the current unreleased v1.0.15 candidate showed Pool Solar physically converging correctly (Solar ON, pump eventually 2900 RPM) while PoolOS relinquished ownership during the ramp because the accepted pump step temporarily lacked usable authoritative RPM evidence. Fresh wrong RPM already remains pending until the fixed deadline; this PR makes temporary missing/stale/unusable evidence for an already-accepted pump speed/flow step behave the same way. The immutable receipt-bound verification deadline is unchanged, fresh hydraulic contradictions still fail immediately, and no freshness/timestamp/ownership rule is weakened. Adds regressions proving missing RPM can recover before the deadline and still times out if it never appears.