Repository navigation
Add Prettier with a pre-commit hook, and format the tree - #89
Merged
Merged
Conversation
One style across the repo: single quotes, no semicolons, 120 wide, trailing commas. It is the style lib/, cli/ and tests/ were already written in; the UI's double quotes and semicolons go with it. The pre-commit hook runs lint-staged, which formats only the files being committed. npm run format and format:check cover the whole tree. Only code is formatted, not markdown, JSON or CSS: the join prompt in PRODUCT.md is compared character for character with its copy in lib, and a formatter has no business reflowing it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
npm run format, and nothing else. Mostly the UI moving to single quotes and no semicolons, and long calls rewrapped at 120. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
GitHub reads .git-blame-ignore-revs on its own. Locally, git blame needs git config blame.ignoreRevsFile .git-blame-ignore-revs once per clone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Prettier with one style everywhere: single quotes, no semicolons, 120 characters wide, trailing commas.
lib/,cli/andtests/already used this style, so most of the reformat is the UI's double quotes and semicolons.Commits
.prettierrc.json,.prettierignore, husky, and lint-staged. The pre-commit hook formats only the files being committed.npm run formatandnpm run format:checkcover the whole tree.npm run formatand nothing else (100 files)..git-blame-ignore-revs: points at commit 2 so it stays out of blame. GitHub reads this file on its own. Locally, rungit config blame.ignoreRevsFile .git-blame-ignore-revsonce per clone.Only code files are formatted, not markdown, JSON or CSS. A test compares the join prompt in
docs/PRODUCT.mdcharacter for character with its copy inlib, so a formatter shouldn't reflow it.prepare: huskyruns during the Dockernpm citoo. Husky prints a notice there when it finds no.git, and exits 0.Checks
format:check, the typecheck, ESLint, the app suite (608 tests) and the CLI suite (148 tests) all pass on the reformatted tree.Merge order
Merge this after the error-hints PR. Rebase onto
main, re-runnpm run format, and regenerate commit 3 with the new hash.🤖 Generated with Claude Code