Conversation
This doesn't add the code that does the downloading. This adds the code that funnels other UI elements towards allowing for downloading.
davep
added
Enhancement
This is a pretty simple approach for now. The problem I see here is that I probably want to handle downloading via input too, and the like. For now this simply assumes that the data on the end of the URI is available without the need to mess with new certificates or get user input.
While what I had was working, I didn't like where it was going. I want to try, as much as possible, to work via the existing code that handles requests. So let's funnel the requests into a DownloadLocation class that can be fed to the handlers and then they can just save to the target file once all the other work is done. Is the idea anyway. This is just a placeholder for now as I have to go afk.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for unconditionally downloading the content of a link, or conditionally downloading the content of an unsupported URI.
Closes #478.