Match line-number font-size to the pre element - #30
Open
bluzername wants to merge 1 commit into
Open
Conversation
The gutter had a fixed 0.875rem font-size but only copy lineHeight and paddingBlockStart from the pre. When a page set a different font-size on the pre (like the codepen in the issue), the numbers stop lining up with the code because font-size affect the line box too, not just line-height. Fixes davatron5000#14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14.
The gutter always use a fixed 0.875rem font-size, and
#alignLineNumbersonly copylineHeightandpaddingBlockStartfrom the pre element, notfontSize. So when a page set its own font-size on the pre (like the codepen in the issue), the line numbers stop lining up with the code, because font-size also change the line box height, not only line-height.Fix is one line: also copy
fontSizefrom the pre computed style, same as the other two properties already do.Added a Playwright test that set
font-size: 20pxon the pre (a size that do not match the gutter default) and check the gutter font-size now match. It fail on main and pass with the fix.npm testis green (33/33).