fix(ci): resolve docs build failure and gitleaks false positive#1
Open
daudee215 wants to merge 2 commits into
Open
fix(ci): resolve docs build failure and gitleaks false positive#1daudee215 wants to merge 2 commits into
daudee215 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two CI failures on
main: broken docs build and a gitleaks false positive.1. Docs build (
mkdocs build --strict)docs/changelog.md: The link[ROADMAP.md](../ROADMAP.md)used a relative path pointing outsidedocs_dir. mkdocs--strictmode rejects out-of-tree relative links.Fixed by replacing with the absolute GitHub URL:
2. Gitleaks secret scan
Gitleaks flagged a false positive
sidekiq-secretmatch inREADME.mdat line 42 (fingerprint:README.md:sidekiq-secret:42). No actual secret is present — the pattern matches on coincidental content.Fixed by adding
.gitleaksignorewith the exact fingerprint to allowlist this known false positive.