Convert-DbaIndexToTable - Stop eating the caller loop when no instance is given - #10705
Open
andreasjordan wants to merge 1 commit into
Open
Convert-DbaIndexToTable - Stop eating the caller loop when no instance is given#10705andreasjordan wants to merge 1 commit into
andreasjordan wants to merge 1 commit into
Conversation
…e is given Stop-Function -Continue runs PowerShell's continue. No loop encloses this call site inside the command, so the continue unwound out of the command and consumed an iteration of whatever loop the caller runs in: a user's foreach silently skipped an element, and Pester's runner corrupted. The escape only bites the non-EnableException path; with EnableException Stop-Function throws before it gets there. Latent: the only caller, Invoke-DbaDbDataMasking, always passes SqlInstance and calls it inside its table loop, so the site could not fire and the continue would have been caught. No red-on-old test exists for a latent escape. Part of #10638 (do Convert-DbaIndexToTable) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
potatoqualitee
approved these changes
Sep 13, 2026
potatoqualitee
left a comment
potatoqualitee
left a comment
Member
There was a problem hiding this comment.
The missing-instance path now exits only the helper invocation instead of terminating the caller loop, with no change to successful conversions. The relevant command coverage passes; the failing COPY lane is unrelated Remove-DbaDatabaseSafely coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #10638, the sweep for
Stop-Function -Continueoutside an enclosing loop. Same shape as #10637.Problem
Convert-DbaIndexToTablerejects a missing-SqlInstancein its begin block withStop-Function -Continue(private/functions/Convert-DbaIndexToTable.ps1:18). No loop encloses that site inside the command, so without-EnableExceptionthecontinueunwinds out of the command and consumes an iteration of whatever loop the caller runs in. The only caller,Invoke-DbaDbDataMasking, always passesSqlInstanceand calls it inside its table loop, so the site cannot fire and the continue would be caught. Latent.What changed
The
-Continueis dropped and an explicitreturnends the block for that input, as in #10637. Nothing else changes.Tests
No new test: no red-on-old exists for a latent escape. The caller's test file passes on both editions through the testing-dbatools harness.
created by Claude and reviewed by Andreas Jordan
🤖 Generated with Claude Code