Export-DbaDacPackage - Stop eating the caller loop when only ExcludeDatabase is given - #10702
Open
andreasjordan wants to merge 1 commit into
Open
Export-DbaDacPackage - Stop eating the caller loop when only ExcludeDatabase is given#10702andreasjordan wants to merge 1 commit into
andreasjordan wants to merge 1 commit into
Conversation
…atabase is given Stop-Function -Continue runs PowerShell's continue. No loop encloses this call site inside the command, so the continue unwound out of the command and consumed an iteration of whatever loop the caller runs in: a user's foreach silently skipped an element, and Pester's runner corrupted. The escape only bites the non-EnableException path; with EnableException Stop-Function throws before it gets there. Part of #10638 (do Export-DbaDacPackage) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
potatoqualitee
approved these changes
Sep 13, 2026
potatoqualitee
left a comment
Member
There was a problem hiding this comment.
The ExcludeDatabase-only validation path now exits the command invocation without terminating its caller loop, while normal export behavior is preserved. Targeted Windows PowerShell coverage and all applicable exact-head checks pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #10638, the sweep for
Stop-Function -Continueoutside an enclosing loop. Same shape as #10637.Problem
Export-DbaDacPackagerejects a call that names neither-Databasenor-AllUserDatabases(only-ExcludeDatabasepasses the earlier check) withStop-Function -Continue(public/Export-DbaDacPackage.ps1:168). No loop encloses that site inside the command, so without-EnableExceptionthecontinueunwinds out of the command and consumes an iteration of whatever loop the caller runs in. Proven in the lab with the plain-script recipe: three calls in aforeachleft the loop counter at 0 on development and at 3 with the fix.What changed
The
-Continueis dropped and an explicitreturnends the block for that input, as in #10637. Nothing else changes. The check still fires before any connection is made.Tests
New context
When only ExcludeDatabase is given: three calls in a loop, asserting the loop count and the warning. Through the testing-dbatools harness: green on both editions with the fix; the plain-script proof above is the red-on-old.created by Claude and reviewed by Andreas Jordan
🤖 Generated with Claude Code