Skip to content

Restore-DbaDatabase - Honor EnableException in the backup information pipeline #10631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potatoqualitee merged 1 commit into from
Sep 11, 2026
+79 −2
Merged

Restore-DbaDatabase - Honor EnableException in the backup information pipeline #10631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions public/Restore-DbaDatabase.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,7 +676,12 @@ function Restore-DbaDatabase {

if ($RestoreInstance.VersionMajor -eq 8 -and $true -ne $TrustDbBackupHistory) {
foreach ($file in $Path) {
$bh = Get-DbaBackupInformation -SqlInstance $RestoreInstance -Path $file
$splatBackupInformation = @{
SqlInstance = $RestoreInstance
Path = $file
EnableException = $EnableException
}
$bh = Get-DbaBackupInformation @splatBackupInformation
$bound = $PSBoundParameters
$bound['TrustDbBackupHistory'] = $true
$bound['Path'] = $bh
Expand Down Expand Up @@ -752,6 +757,7 @@ function Restore-DbaDatabase {
IgnoreLogBackup = $IgnoreLogBackup
StorageCredential = $StorageCredential
NoXpDirRecurse = $NoXpDirRecurse
EnableException = $EnableException
}
$BackupHistory += Get-DbaBackupInformation @parms
}
Expand Down Expand Up @@ -815,7 +821,7 @@ function Restore-DbaDatabase {
}
if ($PSCmdlet.ParameterSetName -like "Restore*") {
if ($BackupHistory.Count -eq 0 -and $RestoreInstance.VersionMajor -ne 8) {
Write-Message -Level Warning -Message "No backups passed through. `n This could mean the SQL instance cannot see the referenced files, the file's headers could not be read or some other issue"
Stop-Function -Message "No backups passed through. `n This could mean the SQL instance cannot see the referenced files, the file's headers could not be read or some other issue"
return
}
Write-Message -message "Processing DatabaseName - $DatabaseName" -Level Verbose
Expand Down Expand Up @@ -859,6 +865,7 @@ function Restore-DbaDatabase {
ContinuePoints = $ContinuePoints
LastRestoreType = $LastRestoreType
DatabaseName = $DatabaseName
EnableException = $EnableException
}
$FilteredBackupHistory = $BackupHistory | Select-DbaBackupInformation @parms
}
Expand Down
70 changes: 70 additions & 0 deletions tests/Restore-DbaDatabase.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,76 @@ Describe $CommandName -Tag IntegrationTests {
}


Context "Honors EnableException when no full backup anchors the chain #10621" {
BeforeAll {
$PSDefaultParameterValues["*-Dba*:EnableException"] = $true

# Build a full/diff/log chain with one file per backup, so the diff and log never share a
# file with the full (the default backup file name has minute resolution and would hide
# the missing full by accident).
$chainDbName = "dbatoolsci_chaintest_$(Get-Random)"
$null = New-DbaDatabase -SqlInstance $TestConfig.InstanceSingle -Name $chainDbName
$splatChainBackup = @{
SqlInstance = $TestConfig.InstanceSingle
Database = $chainDbName
Path = $backupPath
}
$null = Backup-DbaDatabase @splatChainBackup -Type Full -FilePath "chaintest_full.bak"
$chainDiff = Backup-DbaDatabase @splatChainBackup -Type Diff -FilePath "chaintest_diff.bak"
$chainLog = Backup-DbaDatabase @splatChainBackup -Type Log -FilePath "chaintest_log.trn"

# An existing directory without any backup files, to hit the "No backups passed through" path.
$emptyBackupDir = "$backupPath\emptydir"
$null = New-Item -Path $emptyBackupDir -ItemType Directory

$PSDefaultParameterValues.Remove("*-Dba*:EnableException")
}

AfterAll {
$PSDefaultParameterValues["*-Dba*:EnableException"] = $true

$null = Get-DbaDatabase -SqlInstance $TestConfig.InstanceSingle -Database $chainDbName | Remove-DbaDatabase

$PSDefaultParameterValues.Remove("*-Dba*:EnableException")
}

It "Throws when only diff and log are passed with EnableException" {
$splatRestore = @{
SqlInstance = $TestConfig.InstanceSingle
Path = $chainDiff.BackupPath, $chainLog.BackupPath
DatabaseName = $chainDbName
WithReplace = $true
EnableException = $true
}
{ Restore-DbaDatabase @splatRestore } | Should -Throw "*Fullname property not found*"
}

It "Still warns and returns nothing without EnableException" {
$splatRestore = @{
SqlInstance = $TestConfig.InstanceSingle
Path = $chainDiff.BackupPath, $chainLog.BackupPath
DatabaseName = $chainDbName
WithReplace = $true
WarningAction = "SilentlyContinue"
}
$results = Restore-DbaDatabase @splatRestore
$WarnVar | Should -BeLike "*Fullname property not found*"
$results | Should -BeNullOrEmpty
}

It "Throws when the path holds no backups at all with EnableException" {
$splatRestore = @{
SqlInstance = $TestConfig.InstanceSingle
Path = $emptyBackupDir
DatabaseName = $chainDbName
WithReplace = $true
EnableException = $true
}
{ Restore-DbaDatabase @splatRestore } | Should -Throw "*No backups passed through*"
}
}


Context "Database is restored with correct renamings" {
BeforeAll {
$null = Get-DbaDatabase -SqlInstance $TestConfig.InstanceSingle -ExcludeSystem -EnableException | Remove-DbaDatabase -EnableException
Expand Down