fix(nyc-taxi): stop tag/term attachments overwriting each other; create owner corpGroup; honest dry-run - #220
Open
simpleciki wants to merge 2 commits into
Open
Conversation
…te owner corpGroup; honest dry-run Per-table accumulation for globalTags/glossaryTerms aspects (one emit per table with the full list — no more last-write-wins); create the data_platform_team corpGroup entity before attaching ownership; --dry-run now prints planned changes and "DRY RUN — no changes made"; UTF-8 stdout reconfigure so the script's Unicode output no longer crashes default Windows consoles (datahub-project#211).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #218. Also fixes the Windows Unicode crash reported in #211 for this script.
Four fixes in
datasets/nyc-taxi/add_metadata.py:attach_tags/attach_glossarynow build the full association list per table and emit one aspect per table, so attachments no longer overwrite each other (previously each emit replaced the wholeglobalTags/glossaryTermsaspect with a single association — last write wins, and every table ended up with onlypipeline_stage). Verified on a quickstart instance (server v1.5.0.6): end state matches the README's Metadata section exactly — raw_trips/staging_trips carry 4 tags + 2 terms, mart carries daily_refresh + pipeline_stage and Freshness SLA + Empty Load + Pipeline Stage.create_groups()emitscorpGroupInfofordata_platform_teambefore ownership attachment; the owner chip in the UI now resolves instead of "Not Found".--dry-runnow prints the planned tag/term/ownership operations and ends with "DRY RUN — no changes made" instead of the unconditional "✅ Metadata complete" banner (matching whatadd_lineage.py --dry-runalready does).sys.stdout.reconfigureat startup fixes it for this script (tested on a native cp1252 console, exit 0). The same two-liner applies to the other dataset scripts if you'd like a follow-up.No changes to lineage, ingestion recipes, or the .db files.