Apply cargo fmt#63
Open
adriangb wants to merge 2 commits into
Open
Conversation
Remove stray blank lines left behind when the DataFusion 54 upgrade removed the `as_any` methods from the `ScalarUDFImpl` impls, so `cargo fmt --all -- --check` passes. https://claude.ai/code/session_01H3jbXkVZam7VH5DpiXczBR
adriangb
force-pushed
the
claude/fmt-cleanup-as-any-vg9o8j
branch
from
b884e4b to
7d81a10
Compare
The unit tests (test_int_scalar_float_value, test_bool_scalar_int_value, test_bool_scalar_variant_array_paths) and the variant_get_bool / variant_get_int sqllogictest files were left asserting the old NULL behavior in datafusion-contrib#62, but parquet-variant 58.3 already coerces numeric variants (10.5 -> 10, nonzero -> true). Update the expectations to match the actual coercion behavior so the test suite passes on the current dependency versions. https://claude.ai/code/session_01H3jbXkVZam7VH5DpiXczBR
adriangb
force-pushed
the
claude/fmt-cleanup-as-any-vg9o8j
branch
from
381b6fe to
5f2a416
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove stray blank lines left behind when the DataFusion 54 upgrade removed the
as_anymethods from theScalarUDFImplimpls, socargo fmt --all -- --checkpasses.