fix: auto-prune missing profile bundles and allow custom Windows installation paths - #113
Merged
yaojin3616 merged 1 commit intoAug 20, 2026
Conversation
…ry Windows install paths
yaojin3616
deleted the
codex/auto-prune-missing-bundles-and-nsis-install
branch
August 20, 2026 12:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
profiles/web/package.jsonbefore running Harness. If any third-party bundle listed indsh.profile.bundlesordependenciesis missing fromnode_modules(e.g. manually deleted or uninstalled), Desktop automatically cleans up the stale bundle declarations andpnpm-lock.yaml. This prevents Harness from crashing withcannot resolve profile bundle.pnpm-lock.yamlis cleaned upon plugin reset/uninstall so pnpm does not crash withlockfileToHoistedDepGraphduring subsequent plugin installs.D:\dsh-desktop) without requiring pre-existing folders by using an NSISLEAVEhook to create the directory tree and overriding.onVerifyInstDir.Verification
npm run typecheckpassednpm testpassed (27 test suites, 172 tests)npm run buildpassed