AND-248: isolate macOS Harness TCC responsibility - #107
Open
yaojin3616 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
disclaim: trueboundaryRoot cause
DSH Desktop used ordinary
child_process.spawnfor the Harness on every platform. On macOS, Harness loads user-installed plug-ins and can launch third-party tools, but the ordinary child process remained in DSH Desktop's responsibility chain. TCC activity initiated below that boundary could therefore be attributed toio.dsh.desktop, even though the desktop main process does not call the Accessibility APIs itself.Electron exposes
utilityProcess.fork({ disclaim: true })for this case: macOS treats the child as a separate entity for TCC responsibility. The new path is limited to macOS; other platforms retain the existing bundled runtime.Fixes #86.
Closes AND-248.
Verification
npm run typechecknpm test— 27 files, 170 tests passednpm run buildgit diff --checkRemaining verification
A second end-to-end development launch was not performed because another DSH Desktop developer instance is already running under the same Electron application identity. It was left untouched. The macOS utility-process launch contract is covered by regression tests, but the TCC attribution change should also be confirmed on a signed macOS build during review.