Skip to content

init snowflake importer#1028

Merged
jochenchrist merged 76 commits into
datacontract:mainfrom
dmaresma:feat/snowflake_importer
Jun 4, 2026
Merged

init snowflake importer#1028
jochenchrist merged 76 commits into
datacontract:mainfrom
dmaresma:feat/snowflake_importer

Conversation

@dmaresma
Copy link
Copy Markdown
Contributor

@dmaresma dmaresma commented Jan 25, 2026

  • Tests pass
  • ruff format
  • README.md updated (if relevant)
  •  CHANGELOG.md entry added

implement #1027 the snowflake importer, enjoy

Copy link
Copy Markdown
Contributor

@jochenchrist jochenchrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test for this importer?

@dmaresma dmaresma requested a review from jochenchrist February 1, 2026 15:32
Copy link
Copy Markdown
Collaborator

@jschoedl jschoedl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already did two small changes.

Comment thread datacontract/imports/snowflake_importer.py
Comment thread datacontract/imports/snowflake_importer.py Outdated
Comment thread datacontract/imports/snowflake_importer.py Outdated
Comment thread datacontract/imports/snowflake_importer.py Outdated
Comment thread datacontract/imports/snowflake_importer.py Outdated
Comment thread datacontract/imports/snowflake_importer.py
Comment thread tests/test_import_snowflake.py Outdated
Comment thread tests/test_import_snowflake.py Outdated
Comment thread tests/test_import_snowflake.py
Comment thread README.md
@dmaresma dmaresma requested a review from jschoedl May 12, 2026 23:15
Comment thread tests/test_import_snowflake.py Outdated
Comment thread tests/test_import_snowflake.py Outdated
Comment thread datacontract/imports/snowflake_importer.py Outdated
Comment thread datacontract/imports/snowflake_importer.py Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
@jochenchrist jochenchrist merged commit 4c09803 into datacontract:main Jun 4, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants