feat: add FTS EU Grants explorer page#191
Merged
Merged
Conversation
Member
Author
|
PR pronta per review. Ho sistemato anche la verifica locale su Windows: ora |
Gabrymi93
approved these changes
Jul 3, 2026
Gabrymi93
left a comment
Member
There was a problem hiding this comment.
Review PR #191 — FTS EU Grants
Clip: 3 file (loader + pagina + themes), solido, perimetro stretto.
Findings
- Low: data loader custom (non usa
load_dataset) ma giustificato — 6 query aggregate diverse, impossibile conload_dataset. - Low: classificazione programmi con
ILIKEbasata su pattern testuali. Caveat già dichiarato nei Limiti. ✅
Checklist
- ✅
safe_connect(),format-utils.js,themes.json.py - ✅ Niente
toLocaleString,tableFormatin celle separate - ✅ Frontmatter + Limiti completi
- ✅ Build/lint/test dichiarati passati
Verdict: merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sintesi
Aggiunge una pagina Data Explorer per
fts_eu_grantscon taglio BI: KPI annuali, distribuzione per programma UE, tipo beneficiario, città dichiarata e tabella dei principali beneficiari.Contesto collegato
Closes #186
Cosa cambia
Checklist nuovo dataset
Se la PR aggiunge un nuovo dataset in explorer:
src/data/fts-eu-grants.json.py— usasafe_connect()(nonduckdb.connect())src/dataset/fts-eu-grants.md— usa moduli condivisi (format-utils.js)src/data/themes.json.py(sidebar auto-generata, non toccatoobservablehq.config.js)title,description,source,source_url,period,last_modified,dataset_slugStandard check
Prima della review, verificare:
toLocaleString— usarenum(),euro(),pct()daformat-utils.jstableFormateInputs.tablein celle separate (bug noto OF)duckdb.connect()— usasafe_connect()themes.json.py— non modificatoobservablehq.config.jsVerifica
npm run lint npm test npm run buildnpm run lint— eslint + standard check: 30 pagine, 0 errorinpm test— JS 57/57 pass, Python 13/13 passnpm run build— build completato: 39 pagine renderizzate, 26 link validatiHo verificato le query del loader direttamente sui parquet pubblici via DuckDB: 40.449 righe 2020-2024, 108,6 mld euro di importo contrattato, aggregazioni programma/tipo ente/città/top beneficiari senza errori.
Checklist PR
Note per chi revisiona
La pagina segnala esplicitamente due caveat: FTS non sostituisce OpenCoesione/fondi strutturali e la città del beneficiario può mancare (
-), quindi la vista territoriale è una lettura della localizzazione dichiarata, non della destinazione finale dei fondi.