[AIGTWY-4789] Fix managed MCP/Skills display in configure summary - #740
Open
david-siqi-liu wants to merge 1 commit into
Open
david-siqi-liu wants to merge 1 commit into
david-siqi-liu wants to merge 1 commit into
Conversation
david-siqi-liu
added
the
quicktree-assisted
david-siqi-liu
marked this pull request as ready for review
September 18, 2026 15:14
The Configuration panel showed "none configured" for MCPs/Skills even when
the admin set them: it read the raw `mcp_servers`/`skills` selector, which for
a UC location is just a `{unity_catalog_location}` pointer with no names or
count (and the MCP branch iterated the dict as a list of server dicts, so it was
always empty).
Source the panel from what ug actually registered/downloaded instead — MCP
servers from state, managed skills from disk — and render each as `N (name, ...)`.
This gives a real count and names uniformly, drops the vague "all under" text,
and drops the now-stale "(pending)" label (registration/download happens during
`ug configure`, before this panel prints).
Co-authored-by: Isaac <no-reply@databricks.com>
david-siqi-liu
force-pushed
the
david/ug-configure-box
branch
from
September 18, 2026 15:22
48985a3 to
75ae355
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ug configure(andug status) rendered a Configuration panel showingMCPs: none configuredandSkills: none configuredeven when the workspace admin had configured them, e.g.mcp_servers: {unity_catalog_location: main.davidl}andskills: {unity_catalog_location: xsh.xsh_oncall_skills}. The MCP servers were actually registered (theRegistered workspace MCP server(s): ...line proves it), so the panel was misreporting.Cause
_print_managed_summaryread the admin's rawmcp_servers/skillsselector. Afternormalize_managed_configeach is aNamesOrLocationselector, either{names: [...]}or{unity_catalog_location: <cat>.<schema>}. A UC location is just a pointer with no names or count, and the MCP branch iterated the value as a list of server dicts with anamekey, which for a dict yields its string keys, so the list was always empty (broken for both selector forms).Fix
Source the panel from what ug actually registered/downloaded, which it already persists: MCP servers from state (
managed_mcp_servers) and managed skills from disk (records_for_scope("managed")). Each line now renders asN (name, name), so the count and names show uniformly, with no "all under" text and no need to resolve the UC location in this network-free summary.ug configurereloads state after reconcile so the panel counts the servers it just registered;ug statusreads the same persisted set.Also dropped the
(pending)label: it dates from when this panel previewed the admin's config before ug did any local registration. Registration and skill download now happen duringug configureright before the panel prints (and are already applied byug status), so(pending)was stale.Behavior in the reporter's case:
MCPs: 2 (main-davidl-github, main-davidl-mock_mcp_server), and since all five skills failed to download with HTTP 500 (a separate server-side issue, warned above the panel),Skills: none configured— the honest applied state.Testing
pytest tests/test_cli.pypasses (369 tests);ruff checkandruff format --checkare clean. Run offline via the sibling venv since PyPI is unreachable in the sandbox.This pull request and its description were written by Isaac.