Skip to content

Remove the deprecated ug configure skills command - #732

Open
xsh310 wants to merge 1 commit into
skills-bare-configure-mcpfrom
remove-ug-configure-skills
Open

xsh310 wants to merge 1 commit into
skills-bare-configure-mcpfrom
remove-ug-configure-skills

Conversation

@xsh310

@xsh310 xsh310 commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

What changed and why

ug configure skills is now fully covered by the ug skills commands, so this removes it:

  • a bare ug skills registers the schema-less skills MCP connection (what ug configure skills with no --location did);
  • ug skills add / ug skills remove (with or without --mcp) manage MCP scopes and downloads (what ug configure skills --location / --skill / --mcp did).

Removed:

  • the ug configure skills command in cli.py;
  • its now-dead configure_skills_mcp_command helper in mcp.py;
  • the tests that covered them (TestConfigureSkillsCommand, TestConfigureSkillsMcpCommand).

Also repointed the ug status note and two comments that named the old command. ug configure itself is unchanged (bare ug configure still runs via its callback); ug configure skills now reports "No such command".

How do you know it works?

  • uv run ruff format --check and uv run ruff check are clean, and the unit suite passes (the one failing test is the pre-existing live-gateway e2e case, unrelated to this change).
  • ug configure --help renders, ug configure skills returns "No such command 'skills'", and the ug skills surface is unchanged.

Stack

Stacked on #729 (its base is that PR's branch); depends on #729 landing first.

This pull request and its description were written by Isaac.

@xsh310
xsh310 added this pull request to stack #733 September 18, 2026 04:27
@xsh310 xsh310 changed the title remove ug configure skills Remove the deprecated ug configure skills command Sep 18, 2026
@xsh310
xsh310 force-pushed the remove-ug-configure-skills branch from 25146bf to b66068a Compare September 18, 2026 05:01
@xsh310
xsh310 marked this pull request as ready for review September 18, 2026 05:18
@xsh310
xsh310 force-pushed the remove-ug-configure-skills branch from b66068a to 5464348 Compare September 18, 2026 05:18

@sunishsheth2009 sunishsheth2009 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to update any ReadMe file?

@xsh310

xsh310 commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator Author

Good question. No README change is needed here: the README never documented ug configure skills, so removing it leaves nothing stale (rg -i 'configure skills' README.md returns nothing). The skills workflow the README documents is the ug skills family (bare ug skills, ug skills add, ug skills remove, ug skills list), and that section was already refreshed in #729 (the PR directly below this one in the stack), including the new bare ug skills entry.

`ug skills` now covers everything `ug configure skills` did: a bare `ug skills`
registers the schema-less connection, and `ug skills add`/`remove` manage MCP
scopes and downloads. Drop the command and its now-dead configure_skills_mcp_command
helper, repoint the stale references that named it, and remove the tests that
covered it.

Co-authored-by: Isaac <no-reply@databricks.com>
@xsh310
xsh310 force-pushed the remove-ug-configure-skills branch from 5464348 to 7aa76d9 Compare September 18, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants