Conversation
xsh310
added this pull request to stack #733
September 18, 2026 04:27
ug configure skills command
xsh310
force-pushed
the
remove-ug-configure-skills
branch
from
September 18, 2026 05:01
25146bf to
b66068a
Compare
xsh310
marked this pull request as ready for review
September 18, 2026 05:18
xsh310
force-pushed
the
remove-ug-configure-skills
branch
from
September 18, 2026 05:18
b66068a to
5464348
Compare
sunishsheth2009
approved these changes
Sep 18, 2026
sunishsheth2009
left a comment
Collaborator
There was a problem hiding this comment.
Don't we need to update any ReadMe file?
Collaborator
Author
|
Good question. No README change is needed here: the README never documented |
`ug skills` now covers everything `ug configure skills` did: a bare `ug skills` registers the schema-less connection, and `ug skills add`/`remove` manage MCP scopes and downloads. Drop the command and its now-dead configure_skills_mcp_command helper, repoint the stale references that named it, and remove the tests that covered it. Co-authored-by: Isaac <no-reply@databricks.com>
xsh310
force-pushed
the
remove-ug-configure-skills
branch
from
September 18, 2026 15:31
5464348 to
7aa76d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
ug configure skillsis now fully covered by theug skillscommands, so this removes it:ug skillsregisters the schema-less skills MCP connection (whatug configure skillswith no--locationdid);ug skills add/ug skills remove(with or without--mcp) manage MCP scopes and downloads (whatug configure skills --location/--skill/--mcpdid).Removed:
ug configure skillscommand incli.py;configure_skills_mcp_commandhelper inmcp.py;TestConfigureSkillsCommand,TestConfigureSkillsMcpCommand).Also repointed the
ug statusnote and two comments that named the old command.ug configureitself is unchanged (bareug configurestill runs via its callback);ug configure skillsnow reports "No such command".How do you know it works?
uv run ruff format --checkanduv run ruff checkare clean, and the unit suite passes (the one failing test is the pre-existing live-gateway e2e case, unrelated to this change).ug configure --helprenders,ug configure skillsreturns "No such command 'skills'", and theug skillssurface is unchanged.Stack
Stacked on #729 (its base is that PR's branch); depends on #729 landing first.
This pull request and its description were written by Isaac.