Derive UG_ENABLE_MODEL_DISCOVERY from managed MPS - #694
Open
andy-xu-db wants to merge 3 commits into
Open
andy-xu-db wants to merge 3 commits into
andy-xu-db wants to merge 3 commits into
Conversation
This was referenced Sep 16, 2026
andy-xu-db
force-pushed
the
stack/codex/model-discovery-flag
branch
2 times, most recently
from
September 16, 2026 22:54
6676365 to
5373122
Compare
andy-xu-db
changed the title
andy-xu-db
force-pushed
the
stack/codex/model-discovery-flag
branch
from
September 17, 2026 02:23
5373122 to
87312dc
Compare
andy-xu-db
changed the title
This was referenced Sep 17, 2026
lilly-luo
reviewed
Sep 17, 2026
Comment on lines
+2210
to
+2219
| if managed_provider and explicit_provider is not None: | ||
| raise RuntimeError( | ||
| f"--provider cannot be used for {TOOL_SPECS[tool]['display']} because your admin " | ||
| f"has configured managed provider {managed_provider}." | ||
| ) | ||
| if managed_provider and parent_schema is not None: | ||
| raise RuntimeError( | ||
| f"--model-location cannot be used for {TOOL_SPECS[tool]['display']} because your " | ||
| f"admin has configured managed provider {managed_provider}." | ||
| ) |
Collaborator
There was a problem hiding this comment.
can you nest this a lil bit?
if managed_provider:
if explicit_provider is not None:
xxx
if parent_schema is not None:
yyyy
Collaborator
Author
There was a problem hiding this comment.
changed to nested structure
lilly-luo
reviewed
Sep 17, 2026
Comment on lines
+2220
to
+2221
| if parent_schema is not None: | ||
| provider = None |
Collaborator
There was a problem hiding this comment.
add a comment saying that this should not be possible configuration on the admin config
lilly-luo
reviewed
Sep 17, 2026
Collaborator
There was a problem hiding this comment.
can u do an audit of these tests and make sure they're all adding value? a lot of monkey patch becomes...less valuable
Collaborator
Author
There was a problem hiding this comment.
removed excessive tests
lilly-luo
approved these changes
Sep 17, 2026
andy-xu-db
force-pushed
the
stack/codex/model-discovery-flag
branch
from
September 17, 2026 16:13
cf5e1d1 to
a3b48e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
Summary
UG_ENABLE_MODEL_DISCOVERY=1for the selected agent's managed MPS.0otherwise.Reference
models.model_provider_service.Test
Testing using this workspace config:
