Skip to content

Make Claude picker ownership crash-safe #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andy-xu-db wants to merge 1 commit into
base: codex/managed-model-location
Choose a base branch
from
Open

Make Claude picker ownership crash-safe #684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions src/ucode/agents/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@
)
from ucode.managed_config import refresh_managed_config
from ucode.managed_files import managed_write_batch
from ucode.state import get_provider_service, load_state, save_state
from ucode.state import get_provider_service, load_state
from ucode.state import save_state as save_state
from ucode.telemetry import agent_version
from ucode.ui import (
print_err,
Expand Down Expand Up @@ -519,11 +520,9 @@ def configure_single_tool(tool: str, state: dict) -> dict:
raise RuntimeError(
f"{TOOL_SPECS[tool]['display']} is not available on this workspace.{detail}"
)
state["available_tools"] = list(set((state.get("available_tools") or []) + [tool]))
with managed_write_batch(_managed_settings_displays([tool])):
state = _configure_one(tool, state, provider)
available_tools = list(set((state.get("available_tools") or []) + [tool]))
state["available_tools"] = available_tools
save_state(state)
return state


Expand Down Expand Up @@ -562,11 +561,10 @@ def configure_selected_tools(
"""
with managed_write_batch(_managed_settings_displays(tools)):
for tool in tools:
existing = state.get("available_tools") or []
state["available_tools"] = sorted(set(existing) | {tool})
state = _configure_one(tool, state, get_provider_service(state, tool))

existing = state.get("available_tools") or []
state["available_tools"] = sorted(set(existing) | set(tools))
save_state(state)
if install_ai_tools:
install_databricks_ai_tools_for_agents(tools, state)
return state
Expand Down
Loading
Loading