Expose Databricks error codes on ApiError.errorCode - #322
Open
parthban-db wants to merge 1 commit into
Open
parthban-db wants to merge 1 commit into
parthban-db wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
Summary
Adds
ApiError.errorCodewhile retaining the existingApiError.codeproperty, so consumers can read Databricks API error codes using the cross-SDK property name without breaking current modular-SDK callers.Why
The modular SDK correctly parses
error_codevalues but exposes them only asApiError.code. AppKit and other Databricks SDK integrations expecterrorCode; this mismatch prevented capability-rejection handling from recognizingINVALID_PARAMETER_VALUEandNOT_IMPLEMENTED, so the SQL Arrow fallback betweenINLINEandEXTERNAL_LINKSdid not run.What changed
Interface changes
ApiError.errorCode: Codeproperty. The existingApiError.codeproperty remains unchanged.Behavioral changes
errorCodeandcodewith the same parsed Databricks error code, including product-specific values not declared as namedCodemembers.Internal changes
How is this tested?
npm run format,npm run build,npm run lint,npm run typecheck, andnpm testpass across the SDK workspace. The changed core package also passes all 210 browser tests against the system-installed Chrome.