Skip to content

Fix duplicate JDBC connection parameters - #1652

Merged
sreekanth-db merged 2 commits into
mainfrom
fix/issue-1648-duplicate-connection-properties
Aug 22, 2026
Merged

Fix duplicate JDBC connection parameters#1652
sreekanth-db merged 2 commits into
mainfrom
fix/issue-1648-duplicate-connection-properties

Conversation

@sreekanth-db

Copy link
Copy Markdown
Collaborator

Description

  • Allow a connection parameter to be supplied in both the JDBC URL and Properties without failing on a duplicate map key.
  • Preserve JDBC URL precedence when duplicate values differ.
  • Add regression coverage for identical and conflicting values with case-insensitive parameter names.

Fixes #1648

Testing

  • DatabricksConnectionContextTest: 147 tests passed.
  • Live warehouse repro confirmed that duplicate parameters connect successfully and the JDBC URL value takes precedence.
  • isaac review --uncommitted: 0 final findings.

Telemetry Errors

  • Not applicable — this PR does not add or change a telemetry-visible error.
  • Applicable — the error uses DatabricksDriverErrorCode where appropriate, and any new code is uniquely numbered and tested.
  • Applicable — its driver/server/user classification is linked, or maintainer help is requested because the author cannot access the classification.

Additional Notes to the Reviewer

The precedence behavior is documented in the helper method and the changelog.

Allow URL and Properties inputs to overlap while preserving URL precedence.

Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>
Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>

@peco-review-bot peco-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No issues identified by the review bot.

@sreekanth-db
sreekanth-db added this pull request to the merge queue Aug 22, 2026
Merged via the queue into main with commit 27f57dc Aug 22, 2026
23 of 24 checks passed
@sreekanth-db
sreekanth-db deleted the fix/issue-1648-duplicate-connection-properties branch August 22, 2026 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Driver.connect fails with "Multiple entries with same key" when a parameter is present in both the JDBC URL and Properties

2 participants