feat: stmt support branch#19774
Conversation
fix fix fix fix fix
github-actions
Bot
added
the
pr-feature
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c0e0a2811
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| continue; | ||
| } | ||
| match catalog | ||
| .get_table_branch(&tenant, &db.name, base_table, branch_name, false) |
There was a problem hiding this comment.
This branch-resolution path calls catalog.get_table_branch(...) directly, which bypasses the normal QueryContext lookup path that applies check_table_ref_access (session flag + enterprise gate). In practice, users can still read branch column metadata via system.columns/SHOW COLUMNS branch filters even when enable_experimental_table_ref=0, so the feature gate is no longer consistently enforced.
Useful? React with 👍 / 👎.
branch support recluster falshback constraint row access branch support compact and analyze index support branch fix branch support dml write truncate refresh virtual column and insert multi table create index fix support undrop branch add system.branches and show branches fix
🤖 CI Job Analysis
📊 Summary
❌ NO RETRY NEEDEDAll failures appear to be code/test issues requiring manual fixes. 🔍 Job Details
🤖 AboutAutomated analysis using job annotations to distinguish infrastructure issues (auto-retried) from code/test issues (manual fixes needed). |
1 participant
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Tests
Type of change
This change is