Skip to content

dealtracker: return result.Error, not shadowed outer err #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parkan merged 2 commits into from
Apr 24, 2026
Merged

dealtracker: return result.Error, not shadowed outer err #671

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
012e114
dealtracker: return result.Error, not shadowed outer err
parkan Apr 23, 2026
92774c8
Merge branch 'main' into fix/dealtracker-wrong-err
parkan Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions service/dealtracker/dealtracker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,7 +623,7 @@ func (d *DealTracker) runOnce(ctx context.Context) error {
Where("deal_type = ? AND end_epoch < ? AND state = 'active'", model.DealTypeMarket, lastEpoch).
Update("state", model.DealExpired)
if result.Error != nil {
return errors.WithStack(err)
return errors.WithStack(result.Error)
}
Logger.Infof("marked %d deals as expired", result.RowsAffected)

Expand All @@ -632,7 +632,7 @@ func (d *DealTracker) runOnce(ctx context.Context) error {
Where("deal_type = ? AND state in ('proposed', 'published') AND start_epoch < ?", model.DealTypeMarket, lastEpoch).
Update("state", model.DealProposalExpired)
if result.Error != nil {
return errors.WithStack(err)
return errors.WithStack(result.Error)
}
Logger.Infof("marked %d deal as proposal_expired", result.RowsAffected)

Expand Down
Loading