Repository navigation
fixes - #45
Open
AbhishekKumar9984 wants to merge 2 commits into
Open
fixes#45AbhishekKumar9984 wants to merge 2 commits into
AbhishekKumar9984 wants to merge 2 commits into
Conversation
AbhishekKumar9984
force-pushed
the
guava_fixes
branch
from
October 27, 2026 11:00
2dd5e1d to
338f33c
Compare
AbhishekKumar9984
force-pushed
the
guava_fixes
branch
from
October 27, 2026 11:07
338f33c to
9c6f289
Compare
deepika-lalwani123
left a comment
deepika-lalwani123
left a comment
There was a problem hiding this comment.
Looks fine overall. One nit inline.
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> | ||
| <guava.version>27.0.1-jre</guava.version> | ||
| <guava.version>32.0.0-jre</guava.version> |
There was a problem hiding this comment.
Please use Guava >= 32.1.3-jre instead of 32.0.0-jre. 32.0.0 has a known regression (temp dir handling), fixed in 32.0.1. Ideally pin it once in dependencyManagement and add a maven-enforcer requireUpperBoundDeps rule rather than per-dependency <exclusion> blocks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue :
Resolved security vulnerabilities (CVE-2023-2976 / CVE-2020-8908) associated with older versions of
com.google.guava:guava(27.0.1-jre) pulled in directly and transitively via plugin dependencies.Root Cause :
pom.xmlusedguavaversion27.0.1-jre(and31.0.1-jrein the e2e profile), while CDAP, Hadoop, andgoogle-cloud-storagedependencies transitively pulled in conflicting Guava versions.Fix :
<guava.version>from27.0.1-jreto32.0.0-jreinpom.xmland removed the31.0.1-jreoverride from the e2e profile.com.google.guava:guavafromio.cdap.plugin:hydrator-common,io.cdap.cdap:cdap-api,io.cdap.cdap:cdap-etl-api,org.apache.hadoop:hadoop-common,com.google.cloud:google-cloud-storage, andio.cdap.tests.e2e:cdap-e2e-framework.Testing evidence: https://docs.google.com/spreadsheets/d/1Cw6Z_k3wlks7sAC4-Kg6FTIMRL7-zxLlsJIXvVJLrb8/edit?gid=0#gid=0