Skip to content

fix(cli): remove api-key logging #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kevinlin09 wants to merge 1 commit into from
Closed

fix(cli): remove api-key logging #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions dashscope/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,8 +225,7 @@ class Oss:
@classmethod
def upload(cls, args):
print(
f"Start oss.upload: model={args.model}, file={args.file}, "
f"api_key={args.api_key}",
f"Start oss.upload: model={args.model}, file={args.file}",
)
Comment on lines 227 to 229

@gemini-code-assist gemini-code-assist Bot Jan 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this change correctly removes the API key from being logged, which is a critical security improvement, it's worth noting that using print() for logging application status is not ideal. It would be better to use a proper logging framework, like Python's logging module. This would provide more flexibility, such as controlling log verbosity and directing logs to different outputs (e.g., stderr or a file), separating them from the primary output of the CLI tool. The project already seems to have a logger set up in other modules (e.g., dashscope.utils.oss_utils), which could be leveraged here as well for better consistency.

if not args.file or not args.model:
print("Please specify the model and file path")
Expand Down
Loading