Skip to content

Dev/sdk cli#155

Merged
lzsweb merged 10 commits into
mainfrom
dev/sdk-cli
Jun 25, 2026
Merged

Dev/sdk cli#155
lzsweb merged 10 commits into
mainfrom
dev/sdk-cli

Conversation

@luk384090-cloud

Copy link
Copy Markdown
Collaborator

Description

[Describe what this PR does and why]

Related Issue: Fixes #[issue_number] or Relates to #[issue_number]

Security Considerations: [Check if API keys or sensitive credentials are exposed in code/logs]

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Refactoring

Component(s) Affected

  • Model
  • Application
  • Common
  • Documentation
  • Tests
  • CI/CD

Checklist

  • Pre-commit hooks pass
  • Tests pass locally
  • Documentation updated (if needed)
  • Ready for review

Testing

[How to test these changes]

Additional Notes

[Optional: any other context]

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly expands the DashScope CLI by adding numerous Typer-based sub-command groups (such as assistants, threads, runs, and various multimodal tasks), translating legacy command formats, and introducing comprehensive unit tests. The code review identified a critical bug in update_assistant where omitting the --file-id option would unintentionally clear existing files. Additionally, the feedback suggests code simplifications and consistency improvements, such as removing a redundant try...except block in files.py and utilizing the shared error helper instead of direct typer.echo and typer.Exit calls in generation.py.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread dashscope/cli/assistants.py Outdated
Comment thread dashscope/cli/files.py Outdated
Comment thread dashscope/cli/generation.py
Comment thread dashscope/cli/generation.py
@lzsweb lzsweb merged commit 84e065e into main Jun 25, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants