Dev/sdk cli#155
Conversation
There was a problem hiding this comment.
Code Review
This pull request significantly expands the DashScope CLI by adding numerous Typer-based sub-command groups (such as assistants, threads, runs, and various multimodal tasks), translating legacy command formats, and introducing comprehensive unit tests. The code review identified a critical bug in update_assistant where omitting the --file-id option would unintentionally clear existing files. Additionally, the feedback suggests code simplifications and consistency improvements, such as removing a redundant try...except block in files.py and utilizing the shared error helper instead of direct typer.echo and typer.Exit calls in generation.py.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Description
[Describe what this PR does and why]
Related Issue: Fixes #[issue_number] or Relates to #[issue_number]
Security Considerations: [Check if API keys or sensitive credentials are exposed in code/logs]
Type of Change
Component(s) Affected
Checklist
Testing
[How to test these changes]
Additional Notes
[Optional: any other context]