Skip to content

Add ocr_options parameter and input validation to MultiModalConversation#154

Merged
lzsweb merged 12 commits into
mainfrom
dev/issue2
Jul 1, 2026
Merged

Add ocr_options parameter and input validation to MultiModalConversation#154
lzsweb merged 12 commits into
mainfrom
dev/issue2

Conversation

@luk384090-cloud

Copy link
Copy Markdown
Collaborator

Description

[Describe what this PR does and why]

Related Issue: Fixes #[issue_number] or Relates to #[issue_number]

Security Considerations: [Check if API keys or sensitive credentials are exposed in code/logs]

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Refactoring

Component(s) Affected

  • Model
  • Application
  • Common
  • Documentation
  • Tests
  • CI/CD

Checklist

  • Pre-commit hooks pass
  • Tests pass locally
  • Documentation updated (if needed)
  • Ready for review

Testing

[How to test these changes]

Additional Notes

[Optional: any other context]

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an ocr_options parameter to the MultiModalConversation.call method and adds input validation to ensure that the input data is not empty before sending a request. The review feedback highlights that these changes (both the ocr_options parameter and the input validation block) are missing from the asynchronous counterpart AioMultiModalConversation.call, and recommends adding them there to maintain feature parity and consistent behavior.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread dashscope/aigc/multimodal_conversation.py
Comment thread dashscope/aigc/multimodal_conversation.py
@lzsweb lzsweb merged commit 218305d into main Jul 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants