Skip to content

Agentic RL支持监听http断开事件#149

Closed
luozirong2025 wants to merge 6 commits into
dashscope:mainfrom
luozirong2025:http
Closed

Agentic RL支持监听http断开事件#149
luozirong2025 wants to merge 6 commits into
dashscope:mainfrom
luozirong2025:http

Conversation

@luozirong2025

Copy link
Copy Markdown
Contributor

Description

[Describe what this PR does and why]

Related Issue: Fixes #[issue_number] or Relates to #[issue_number]

Security Considerations: [Check if API keys or sensitive credentials are exposed in code/logs]

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Refactoring

Component(s) Affected

  • Model
  • Application
  • Common
  • Documentation
  • Tests
  • CI/CD

Checklist

  • Pre-commit hooks pass
  • Tests pass locally
  • Documentation updated (if needed)
  • Ready for review

Testing

[How to test these changes]

Additional Notes

[Optional: any other context]

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements client disconnect detection in the FastAPI server, cancelling the processing task if a disconnect occurs, and adds utility functions for extracting request IDs and business summaries for logging. The review feedback suggests delaying the disconnect listener task creation until after the request body is fully parsed to avoid ASGI message competition, adding a null check for this listener in the 'finally' block to prevent 'AttributeError', and defensively accessing the 'headers' attribute on the request object.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread dashscope/finetune/reinforcement/component/server/server.py Outdated
Comment thread dashscope/finetune/reinforcement/component/server/server.py
Comment thread dashscope/finetune/reinforcement/component/server/server.py Outdated
Comment thread dashscope/finetune/reinforcement/common/utils.py Outdated
luozirong2025 and others added 3 commits June 22, 2026 18:00
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@lzsweb lzsweb closed this Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants