Skip to content

bug fix for multimodal-dialog agent and add parameter speaker_id in asr result #241

Merged
lzsweb merged 3 commits into
dashscope:mainfrom
songguocola:dev/audio_0701
Jul 2, 2026
Merged

bug fix for multimodal-dialog agent and add parameter speaker_id in asr result #241
lzsweb merged 3 commits into
dashscope:mainfrom
songguocola:dev/audio_0701

Conversation

@songguocola

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces graceful shutdown and resource cleanup mechanisms for the WebSocket clients, specifically adding timeout-based graceful stops and idempotent force-close logic in MultiModalDialog, as well as cancellation propagation and retry bailing in OkHttpWebSocketClient. A critical issue was identified in OkHttpWebSocketClient where the isClosed flag is never reset to false after being set to true during a cancellation, which will cause any subsequent requests on a reused client instance to be silently ignored.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@lzsweb lzsweb merged commit c1bf8ce into dashscope:main Jul 2, 2026
3 checks passed
@songguocola songguocola deleted the dev/audio_0701 branch July 2, 2026 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants