bug fix for multimodal-dialog agent and add parameter speaker_id in asr result #241
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces graceful shutdown and resource cleanup mechanisms for the WebSocket clients, specifically adding timeout-based graceful stops and idempotent force-close logic in MultiModalDialog, as well as cancellation propagation and retry bailing in OkHttpWebSocketClient. A critical issue was identified in OkHttpWebSocketClient where the isClosed flag is never reset to false after being set to true during a cancellation, which will cause any subsequent requests on a reused client instance to be silently ignored.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
No description provided.