bug fix for multimodal-dialog agent and add parameter speaker_id in asr result#235
bug fix for multimodal-dialog agent and add parameter speaker_id in asr result#235songguocola wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request improves the lifecycle and connection management in MultiModalDialog and OkHttpWebSocketClient by introducing graceful shutdown timeouts, immediate force-close capabilities, and proper cancellation of upstream streaming subscriptions. Feedback on the changes suggests restoring the interrupted status of the thread when catching InterruptedException in the stop method of MultiModalDialog to ensure correct thread pool behavior.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| } catch (InterruptedException ignored) { | ||
| close(); | ||
| } |
There was a problem hiding this comment.
When catching InterruptedException, it is a best practice to restore the interrupted status of the thread by calling Thread.currentThread().interrupt(). Swallowing the exception without restoring the status can prevent calling threads or thread pools from responding correctly to shutdown or cancellation requests.
} catch (InterruptedException e) {
close();
Thread.currentThread().interrupt();
}
No description provided.