Skip to content

bug fix for multimodal-dialog agent and add parameter speaker_id in asr result#235

Closed
songguocola wants to merge 2 commits into
dashscope:mainfrom
songguocola:dev/audio_0701
Closed

bug fix for multimodal-dialog agent and add parameter speaker_id in asr result#235
songguocola wants to merge 2 commits into
dashscope:mainfrom
songguocola:dev/audio_0701

Conversation

@songguocola

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the lifecycle and connection management in MultiModalDialog and OkHttpWebSocketClient by introducing graceful shutdown timeouts, immediate force-close capabilities, and proper cancellation of upstream streaming subscriptions. Feedback on the changes suggests restoring the interrupted status of the thread when catching InterruptedException in the stop method of MultiModalDialog to ensure correct thread pool behavior.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines 471 to 473
} catch (InterruptedException ignored) {
close();
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

When catching InterruptedException, it is a best practice to restore the interrupted status of the thread by calling Thread.currentThread().interrupt(). Swallowing the exception without restoring the status can prevent calling threads or thread pools from responding correctly to shutdown or cancellation requests.

      } catch (InterruptedException e) {
        close();
        Thread.currentThread().interrupt();
      }

@songguocola songguocola deleted the dev/audio_0701 branch June 30, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant