Skip to content

funasr support payload.input and bug fix in transcription#232

Merged
lzsweb merged 2 commits into
dashscope:mainfrom
songguocola:dev/audio_0618
Jun 17, 2026
Merged

funasr support payload.input and bug fix in transcription#232
lzsweb merged 2 commits into
dashscope:mainfrom
songguocola:dev/audio_0618

Conversation

@songguocola

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces timeout support for asynchronous task waiting across several classes, including AsynchronousApi, Transcription, and QwenTranscription. It also adds new constructors to Recognition to support custom connection options and configures input parameters in RecognitionParam. The review feedback recommends using System.nanoTime() instead of System.currentTimeMillis() to ensure robust, monotonic timeout calculations, and suggests chaining the new constructors in Recognition to eliminate code duplication.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/main/java/com/alibaba/dashscope/api/AsynchronousApi.java
Comment thread src/main/java/com/alibaba/dashscope/api/AsynchronousApi.java
@lzsweb lzsweb merged commit 44b0472 into dashscope:main Jun 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants