Skip to content

funasr support payload.input and bug fix in transcription#231

Closed
songguocola wants to merge 2 commits into
dashscope:mainfrom
songguocola:dev/audio_0618
Closed

funasr support payload.input and bug fix in transcription#231
songguocola wants to merge 2 commits into
dashscope:mainfrom
songguocola:dev/audio_0618

Conversation

@songguocola

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces timeout support for asynchronous task waiting across several API classes and adds WebSocket URL configuration and connection options to the audio recognition service. The review feedback highlights critical improvements: properly handling InterruptedException instead of swallowing it, using monotonic System.nanoTime() instead of System.currentTimeMillis() for robust timeout measurements, and addressing a potential lifecycle issue where updating the WebSocket URL after client initialization may have no effect.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/main/java/com/alibaba/dashscope/api/AsynchronousApi.java
Comment thread src/main/java/com/alibaba/dashscope/api/AsynchronousApi.java
Comment on lines +123 to +125
public void setWebsocketUrl(String websocketUrl) {
serviceOption.setBaseWebSocketUrl(websocketUrl);
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The setWebsocketUrl method modifies the serviceOption instance. However, duplexApi (which is a SynchronizeFullDuplexApi) is already constructed in the constructor using the initial serviceOption.

If SynchronizeFullDuplexApi copies or resolves the WebSocket URL from serviceOption during its construction, calling setWebsocketUrl later will have no effect on the actual connection URL used by duplexApi. Please verify if duplexApi dynamically reads the URL from serviceOption on every call, or if duplexApi needs to be re-initialized or updated when the WebSocket URL changes.

@songguocola songguocola deleted the dev/audio_0618 branch June 16, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant