funasr support payload.input and bug fix in transcription#231
funasr support payload.input and bug fix in transcription#231songguocola wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces timeout support for asynchronous task waiting across several API classes and adds WebSocket URL configuration and connection options to the audio recognition service. The review feedback highlights critical improvements: properly handling InterruptedException instead of swallowing it, using monotonic System.nanoTime() instead of System.currentTimeMillis() for robust timeout measurements, and addressing a potential lifecycle issue where updating the WebSocket URL after client initialization may have no effect.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| public void setWebsocketUrl(String websocketUrl) { | ||
| serviceOption.setBaseWebSocketUrl(websocketUrl); | ||
| } |
There was a problem hiding this comment.
The setWebsocketUrl method modifies the serviceOption instance. However, duplexApi (which is a SynchronizeFullDuplexApi) is already constructed in the constructor using the initial serviceOption.
If SynchronizeFullDuplexApi copies or resolves the WebSocket URL from serviceOption during its construction, calling setWebsocketUrl later will have no effect on the actual connection URL used by duplexApi. Please verify if duplexApi dynamically reads the URL from serviceOption on every call, or if duplexApi needs to be re-initialized or updated when the WebSocket URL changes.
No description provided.