Skip to content

ci: allow ready-for-review label mutation#811

Merged
xdustinface merged 1 commit into
dashpay:devfrom
thepastaclaw:fix-ready-review-label-permission
Jun 15, 2026
Merged

ci: allow ready-for-review label mutation#811
xdustinface merged 1 commit into
dashpay:devfrom
thepastaclaw:fix-ready-review-label-permission

Conversation

@thepastaclaw

@thepastaclaw thepastaclaw commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Motivation

Fixes #809.

The Ready for Review Label workflow uses gh pr edit --add-label / --remove-label to mutate PR labels after CI and CodeRabbit checks pass. PR labels are issue labels in GitHub's API, so the workflow token needs issues: write in addition to the existing pull-request/check permissions.

Changes

  • Grant issues: write to .github/workflows/ready-for-review.yml.

Validation

  • ruby -e 'require "yaml"; YAML.load_file(ARGV[0]); puts "yaml ok"' .github/workflows/ready-for-review.yml
  • git diff --check origin/dev...HEAD
  • Pre-PR code review gate: ship

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow permissions to support enhanced automation capabilities.

@coderabbitai

coderabbitai Bot commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@thepastaclaw, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 45 minutes and 27 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5ad35f27-05be-486a-bc87-d5311a7cbd8d

📥 Commits

Reviewing files that changed from the base of the PR and between 53a1128 and 2b1effc.

📒 Files selected for processing (1)
  • .github/workflows/ready-for-review.yml
📝 Walkthrough

Walkthrough

The ready-for-review.yml workflow gains a single new permission entry: issues: write. This allows the workflow's evaluate job to add and remove labels on pull requests via the GitHub API, which requires issue-level write access.

Changes

Ready-for-Review Workflow Permission Fix

Layer / File(s) Summary
Add issues: write permission
.github/workflows/ready-for-review.yml
issues: write is added to the top-level permissions block alongside the existing pull-requests: write and checks: read, granting the workflow token the ability to mutate PR labels through the GitHub GraphQL API.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 A label to stick, but the token said "nope!"
One line of YAML restored all my hope.
issues: write — such a small little key,
now the ready-for-review tag flows wild and free.
Hop hop, no more GraphQL blocking me! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'ci: allow ready-for-review label mutation' is concise and accurately describes the main change: enabling label mutation by granting the necessary permissions.
Linked Issues check ✅ Passed The PR directly addresses issue #809 by adding issues: write permission to the workflow, which enables the workflow to successfully mutate PR labels using gh pr edit --add-label commands.
Out of Scope Changes check ✅ Passed The change is entirely scoped to the linked issue #809: only the permissions block in the ready-for-review.yml workflow was modified to add the issues: write permission.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/ready-for-review.yml:
- Line 19: Move the `issues: write` permission from the workflow-level
permissions block (currently at the top of the file) to the `evaluate` job's
permissions block only. Remove `issues: write` from the workflow-level
permissions since only the `evaluate` job needs this permission for label
manipulation operations, while the `validate-triggers` job does not require it.
This follows the principle of least privilege by restricting unnecessary
permissions from the workflow level.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 692d46a0-e238-499c-bfe4-1f6f108d3311

📥 Commits

Reviewing files that changed from the base of the PR and between 981e97f and 53a1128.

📒 Files selected for processing (1)
  • .github/workflows/ready-for-review.yml

Comment thread .github/workflows/ready-for-review.yml Outdated
@codecov

codecov Bot commented Jun 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.94%. Comparing base (a132945) to head (2b1effc).
⚠️ Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #811      +/-   ##
==========================================
+ Coverage   72.67%   72.94%   +0.26%     
==========================================
  Files         322      323       +1     
  Lines       71363    71989     +626     
==========================================
+ Hits        51866    52511     +645     
+ Misses      19497    19478      -19     
Flag Coverage Δ
core 76.75% <ø> (+0.21%) ⬆️
ffi 46.99% <ø> (+0.58%) ⬆️
rpc 20.00% <ø> (ø)
spv 90.32% <ø> (+0.01%) ⬆️
wallet 71.64% <ø> (+0.35%) ⬆️
see 34 files with indirect coverage changes

@thepastaclaw thepastaclaw force-pushed the fix-ready-review-label-permission branch from 53a1128 to 2b1effc Compare June 14, 2026 22:39
@thepastaclaw

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 14, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@xdustinface xdustinface merged commit 4d529e4 into dashpay:dev Jun 15, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ready-for-review label workflow lacks label mutation permission

2 participants