chore: bump grovedb to 97250247 (per-instance limit review follow-ups) - #4566
Merged
QuantumExplorer merged 1 commit intoSep 1, 2026
Merged
Conversation
Pulls in grovedb #847 — the P1 fixes from the #844/#845 reviews, which the chained document query surface runs through directly: - instance caps no longer truncate the parent walk (prove/verify could return 0 rows where the trusted read returned data), and empty subquery-matched children charge symmetrically on both sides; - the merge lift treats overlap with the merged root's own selection as a collision instead of silently dropping a root-landing input; - non-Merk layer adapters min-compose child caps on both sides; - versioned serde representation for Query (limit-bearing v3 nested so pre-limit readers fail cleanly), plus fail-closed version gates on the internal walk helpers. No API changes; the workspace compiles untouched. Verified on the new pin: chained e2e 6/6, chained v1 dispatch 5/5, indexOnly 42/42. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
QuantumExplorer
requested review from
ZocoLini,
lklimek,
llbartekll and
shumkov
as code owners
September 1, 2026 00:06
Collaborator
|
🕓 Ready for review — 33 ahead in queue (commit a5c637d) |
QuantumExplorer
deleted the
chore/grovedb-per-instance-limits-followups
branch
September 1, 2026 00:14
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4.2-dev #4566 +/- ##
============================================
- Coverage 87.24% 85.10% -2.15%
============================================
Files 2754 2784 +30
Lines 358943 368868 +9925
============================================
+ Hits 313162 313908 +746
- Misses 45781 54960 +9179
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Pin bump to grovedb
97250247(develop head) — exactly one PR on top of the current pin: grovedb#847, the review follow-ups for #844/#845 (per-instance query limits), which the chained-document-query surface (#4547/#4549, merged) runs through directly.The P1 fixes matter to us: instance caps no longer truncate the parent walk (prove/verify could return 0 rows where the trusted read returned data), empty subquery-matched children charge symmetrically between prover and verifier, non-Merk adapters min-compose child caps on both sides, and the merge lift refuses root-selection overlap instead of silently dropping an input's contribution. Plus a versioned serde representation for
Querywith fail-closed cross-generation decoding.What was done?
Bumped every
grovedb*rev in the six workspace Cargo.tomls + lockfile. No API changes — the workspace compiles untouched.How Has This Been Tested?
On the new pin: chained e2e 6/6 (
cargo test -p drive chained_query_e2e), chained v1 dispatch 5/5 (cargo test -p drive-abci chained), indexOnly 42/42 as the grovedb-heavy smoke;cargo check --workspaceclean. grovedb's own suite at this rev is 5156 passing per #847.Breaking Changes
None.
Checklist:
For repository code-owners and collaborators only
🤖 Generated with Claude Code