Skip to content

chore: bump grovedb to 33a3ad34 (per-instance query limits) - #4564

Merged
QuantumExplorer merged 1 commit into
v4.2-devfrom
chore/grovedb-per-instance-limits-pin
Aug 31, 2026
Merged

chore: bump grovedb to 33a3ad34 (per-instance query limits)#4564
QuantumExplorer merged 1 commit into
v4.2-devfrom
chore/grovedb-per-instance-limits-pin

Conversation

@QuantumExplorer

@QuantumExplorer QuantumExplorer commented Aug 31, 2026

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

Pin bump to grovedb 33a3ad34 (develop head), pulling in exactly two PRs on top of the current pin (0a3b3f9b):

  • grovedb#844 — per-instance query limits (Query::limit): wire format (encoding v3, canonical, fail-closed pre-V4), trusted-read engine, fail-closed gates everywhere else.
  • grovedb#845 — V1 prover/verifier accounting for per-instance limits, and merge lifting (path_query_methods.merge = 2, GROVE_V4): a limited input's global SizedQuery::limit becomes its merged branch's Query::limit, so prove_query_many now serves limited path queries and the verifier re-derives the identical merged query.

Query-side only: no write repricing, no consensus impact, and every already-expressible query keeps its exact wire bytes (grovedb golden pins cover this). The feature activates under GROVE_V4, which PV14 selects.

What was done?

  • Bumped every grovedb* rev in the six workspace Cargo.tomls + lockfile.
  • The two grovedb_query::Query struct literals in the shielded encrypted-notes surface gain the new limit: None field explicitly — the only compile impact in the workspace.

Why now

This is the enabler for serving chained document queries (the provable semi-join stack: #4547#4549#4552#4555) as one merged proof: the limited inner indexOnly page and the derived outer by-ids fetch merge into a single PathQuery whose inner branch carries the lifted per-instance cap — replacing the two-proof + root-equality envelope. That stack will be rebased onto this chore.

How Has This Been Tested?

cargo check --workspace clean; cargo test -p drive index_only (42/42) as the grovedb-heavy smoke; grovedb's own suite at this rev is 5125 passing per #845.

Breaking Changes

None.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes

    • Improved shielded encrypted-notes queries so configured outer ranges can determine the requested note span without unintended inner limits.
  • Maintenance

    • Updated internal database components to compatible revisions, improving consistency across platform, wallet, SDK, and storage functionality.

Pulls in grovedb #844 + #845: per-instance `Query::limit` (wire format,
trusted-read engine, V1 prover/verifier accounting) and the merge
lifting that turns a limited input's global SizedQuery::limit into its
merged branch's per-instance limit — `prove_query_many` now serves
limited path queries and the verifier re-derives the identical merged
query. Query-side only, gated on GROVE_V4 (merge slot 2); no write
repricing, no consensus impact, and every existing query keeps its
exact wire bytes (grovedb golden pins).

The two `grovedb_query::Query` struct literals in the shielded
encrypted-notes surface gain the new `limit: None` field explicitly.

This is what lets a chained document query (provable semi-join) be
served as ONE merged proof: the limited inner indexOnly page and the
derived outer by-ids fetch merge into a single PathQuery whose inner
branch carries the lifted per-instance cap.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions github-actions Bot added this to the v4.2.0 milestone Aug 31, 2026
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 823192e0-979e-4839-a0b2-65326abfe2f5

📥 Commits

Reviewing files that changed from the base of the PR and between 17a2962 and cc008f8.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (8)
  • packages/rs-dpp/Cargo.toml
  • packages/rs-drive-abci/Cargo.toml
  • packages/rs-drive-abci/src/query/shielded/encrypted_notes/v0/mod.rs
  • packages/rs-drive/Cargo.toml
  • packages/rs-drive/src/verify/shielded/verify_shielded_encrypted_notes/v0/mod.rs
  • packages/rs-platform-version/Cargo.toml
  • packages/rs-platform-wallet/Cargo.toml
  • packages/rs-sdk/Cargo.toml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Changes

GroveDB and shielded note query updates

Layer / File(s) Summary
GroveDB dependency revision pins
packages/rs-dpp/Cargo.toml, packages/rs-drive-abci/Cargo.toml, packages/rs-drive/Cargo.toml, packages/rs-platform-version/Cargo.toml, packages/rs-platform-wallet/Cargo.toml, packages/rs-sdk/Cargo.toml
GroveDB Git dependencies now use revision 33a3ad346deca719a82032703f6b33b5b6603aca. Existing features and optional flags remain unchanged.
Shielded note query limits
packages/rs-drive-abci/src/query/shielded/encrypted_notes/v0/mod.rs, packages/rs-drive/src/verify/shielded/verify_shielded_encrypted_notes/v0/mod.rs
The inner encrypted-note queries no longer apply a result limit. Production and test queries set limit: None.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to cc008

This dependency pin updates bounded query and proof behavior without identified impact to correctness, security, or availability. No actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: shumkov, lklimek

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (6 skipped: 6… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: updating GroveDB to revision 33a3ad34 to include per-instance query limits.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (6 skipped: 6 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 2
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/grovedb-per-instance-limits-pin

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thepastaclaw

thepastaclaw commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

🕓 Ready for review — 33 ahead in queue (commit cc008f8)
Queue position: 34/38 · 2 reviews active
ETA: start ~14:47 UTC · complete ~15:52 UTC (median 1h 4m across 30 recent reviews; 2 slots)
Queued 49m ago · Last checked: 2026-08-31 20:50 UTC

@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.17%. Comparing base (17a2962) to head (cc008f8).

Additional details and impacted files
@@             Coverage Diff              @@
##           v4.2-dev    #4564      +/-   ##
============================================
- Coverage     87.57%   85.17%   -2.41%     
============================================
  Files          2748     2778      +30     
  Lines        357005   367741   +10736     
============================================
+ Hits         312647   313220     +573     
- Misses        44358    54521   +10163     
Components Coverage Δ
dpp 83.92% <ø> (-4.46%) ⬇️
drive 83.85% <100.00%> (-2.53%) ⬇️
drive-abci 89.67% <100.00%> (-0.22%) ⬇️
sdk ∅ <ø> (∅)
dapi-client ∅ <ø> (∅)
platform-version ∅ <ø> (∅)
platform-value 92.92% <ø> (ø)
platform-wallet ∅ <ø> (∅)
drive-proof-verifier 48.64% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@QuantumExplorer
QuantumExplorer merged commit cf5f620 into v4.2-dev Aug 31, 2026
19 of 21 checks passed
@QuantumExplorer
QuantumExplorer deleted the chore/grovedb-per-instance-limits-pin branch August 31, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants